Bug 83224 - [Part 4] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
Summary: [Part 4] We should use CSSPropertyID rather than integers when manipulating C...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexis Menard (darktears)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-04 15:05 PDT by Alexis Menard (darktears)
Modified: 2012-04-04 20:08 PDT (History)
7 users (show)

See Also:


Attachments
Patch (16.78 KB, patch)
2012-04-04 15:06 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff
Patch for landing (16.17 KB, patch)
2012-04-04 17:16 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch for landing (24.56 KB, patch)
2012-04-04 17:21 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch for landing (16.17 KB, patch)
2012-04-04 17:33 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2012-04-04 15:05:13 PDT
[Part 4] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
Comment 1 Alexis Menard (darktears) 2012-04-04 15:06:13 PDT
Created attachment 135693 [details]
Patch
Comment 2 Build Bot 2012-04-04 15:44:26 PDT
Comment on attachment 135693 [details]
Patch

Attachment 135693 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12327199
Comment 3 WebKit Review Bot 2012-04-04 16:44:25 PDT
Comment on attachment 135693 [details]
Patch

Attachment 135693 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12329140
Comment 4 Benjamin Poulain 2012-04-04 17:16:00 PDT
Created attachment 135726 [details]
Patch for landing
Comment 5 Benjamin Poulain 2012-04-04 17:21:22 PDT
Created attachment 135727 [details]
Patch for landing
Comment 6 Benjamin Poulain 2012-04-04 17:24:46 PDT
Sorry about that, I do 2 things at the same time and mixed the repositories.
Comment 7 Benjamin Poulain 2012-04-04 17:33:50 PDT
Created attachment 135729 [details]
Patch for landing
Comment 8 WebKit Review Bot 2012-04-04 20:08:28 PDT
Comment on attachment 135729 [details]
Patch for landing

Clearing flags on attachment: 135729

Committed r113281: <http://trac.webkit.org/changeset/113281>
Comment 9 WebKit Review Bot 2012-04-04 20:08:34 PDT
All reviewed patches have been landed.  Closing bug.