Animation related classes should use CSSPropertyId rather than integers when manipulating CSS property ids.
Created attachment 135373 [details] Patch
(In reply to comment #1) > Created an attachment (id=135373) [details] > Patch I'm looking for feedback. The change in blendProperties could maybe be improved.
Created attachment 135376 [details] Patch
Created attachment 135383 [details] Patch
Comment on attachment 135383 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135383&action=review Nice change! > Source/WebCore/platform/animation/Animation.h:184 > + static CSSPropertyID initialAnimationProperty() { return CSSPropertyInvalid; } I don't know that it is worth having initialAnimationProperty() and friends. This was copied from the RenderStyle pattern, but it's only used in one place.
(In reply to comment #5) > (From update of attachment 135383 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135383&action=review > > Nice change! > > > Source/WebCore/platform/animation/Animation.h:184 > > + static CSSPropertyID initialAnimationProperty() { return CSSPropertyInvalid; } > > I don't know that it is worth having initialAnimationProperty() and friends. This was copied from the RenderStyle pattern, but it's only used in one place. It is also used by CSSStyleApplyProperty. I didn't want to touch this guy.
(In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 135383 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=135383&action=review > > > > Nice change! > > > > > Source/WebCore/platform/animation/Animation.h:184 > > > + static CSSPropertyID initialAnimationProperty() { return CSSPropertyInvalid; } > > > > I don't know that it is worth having initialAnimationProperty() and friends. This was copied from the RenderStyle pattern, but it's only used in one place. > > It is also used by CSSStyleApplyProperty. I didn't want to touch this guy. I'll wait EWS to munch it then I cq+. Thanks for the review.
Comment on attachment 135383 [details] Patch Attachment 135383 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12320410 New failing tests: transitions/transition-end-event-all-properties.html fast/forms/validation-message-on-listbox.html fast/forms/validation-message-on-menulist.html transitions/shorthand-border-transitions.html transitions/inherit-other-props.html transitions/hang-with-bad-transition-list.html compositing/repaint/opacity-between-absolute2.html transitions/multiple-mask-transitions.html fast/forms/validation-message-on-radio.html fast/forms/validation-message-on-checkbox.html fast/forms/validation-message-on-range.html transitions/cubic-bezier-overflow-shadow.html fast/forms/validation-message-in-relative-body.html fast/forms/validation-message-appearance.html css3/filters/composited-during-transition-layertree.html transitions/inherit.html fast/forms/validation-message-on-textarea.html compositing/repaint/opacity-between-absolute.html
Created attachment 135423 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
(In reply to comment #8) > (From update of attachment 135383 [details]) > Attachment 135383 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/12320410 > > New failing tests: > transitions/transition-end-event-all-properties.html > fast/forms/validation-message-on-listbox.html > fast/forms/validation-message-on-menulist.html > transitions/shorthand-border-transitions.html > transitions/inherit-other-props.html > transitions/hang-with-bad-transition-list.html > compositing/repaint/opacity-between-absolute2.html > transitions/multiple-mask-transitions.html > fast/forms/validation-message-on-radio.html > fast/forms/validation-message-on-checkbox.html > fast/forms/validation-message-on-range.html > transitions/cubic-bezier-overflow-shadow.html > fast/forms/validation-message-in-relative-body.html > fast/forms/validation-message-appearance.html > css3/filters/composited-during-transition-layertree.html > transitions/inherit.html > fast/forms/validation-message-on-textarea.html > compositing/repaint/opacity-between-absolute.html I'm looking. I ran the Animations tests but forgot the Transitions ones :(.
Comment on attachment 135383 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135383&action=review > Source/WebCore/rendering/RenderLayerBacking.h:-108 > - bool startTransition(double timeOffset, int property, const RenderStyle* fromStyle, const RenderStyle* toStyle); This is another good example of names that should not be removed - fromStyle and toStyle are critical information when understanding what this function does, and should not be removed.
Created attachment 135567 [details] Patch
(In reply to comment #12) > Created an attachment (id=135567) [details] > Patch EWS is green. Dean or Simon you mind reviewing this again. Thanks.
Comment on attachment 135567 [details] Patch Clearing flags on attachment: 135567 Committed r113225: <http://trac.webkit.org/changeset/113225>
All reviewed patches have been landed. Closing bug.