Bug 83003

Summary: Web Inspector: Database::Database::id field in the protocol should have type integer not string
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, haraken, japhet, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Yury Semikhatsky
Reported 2012-04-02 23:36:46 PDT
At the moment it is passed as int but declared as string. The declaration can be easily fixed as the message is still hidden. It was discovered while switching Database domain to the new typed API: https://bugs.webkit.org/show_bug.cgi?id=82958
Attachments
Patch (1.62 KB, patch)
2012-04-02 23:39 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (24.37 KB, patch)
2012-04-03 02:51 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-04-02 23:39:20 PDT
Created attachment 135279 [details] Patch
Pavel Feldman
Comment 2 2012-04-03 00:51:26 PDT
Comment on attachment 135279 [details] Patch I think database ids should be strings (in case we want unique ones).
Yury Semikhatsky
Comment 3 2012-04-03 02:51:57 PDT
Created attachment 135294 [details] Patch
Pavel Feldman
Comment 4 2012-04-03 05:01:39 PDT
Comment on attachment 135294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135294&action=review > Source/WebCore/inspector/Inspector.json:885 > + "id": "DatabaseIdentifier", "DatabaseId"
Yury Semikhatsky
Comment 5 2012-04-03 05:02:37 PDT
(In reply to comment #4) > (From update of attachment 135294 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135294&action=review > > > Source/WebCore/inspector/Inspector.json:885 > > + "id": "DatabaseIdentifier", > > "DatabaseId" Done.
Yury Semikhatsky
Comment 6 2012-04-03 05:08:16 PDT
Committed r113013: <http://trac.webkit.org/changeset/113013>
Note You need to log in before you can comment on or make changes to this bug.