Summary: | Web Inspector: Database::Database::id field in the protocol should have type integer not string | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Yury Semikhatsky <yurys> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, apavlov, bweinstein, haraken, japhet, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Yury Semikhatsky
2012-04-02 23:36:46 PDT
Created attachment 135279 [details]
Patch
Comment on attachment 135279 [details]
Patch
I think database ids should be strings (in case we want unique ones).
Created attachment 135294 [details]
Patch
Comment on attachment 135294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135294&action=review > Source/WebCore/inspector/Inspector.json:885 > + "id": "DatabaseIdentifier", "DatabaseId" (In reply to comment #4) > (From update of attachment 135294 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135294&action=review > > > Source/WebCore/inspector/Inspector.json:885 > > + "id": "DatabaseIdentifier", > > "DatabaseId" Done. Committed r113013: <http://trac.webkit.org/changeset/113013> |