Bug 82970

Summary:

Move correction panel related functions from EditorClient into separated AlternativeTextClient class.

Product:

WebKit

Reporter:

Jia Pu <jiapu.mail>

Component:

New Bugs

Assignee:

Jia Pu <jiapu.mail>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, gustavo, japhet, menard, mrobinson, pnormand, webkit.review.bot, xan.lopez, zoltan

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.7

Bug Depends on:

82942

Bug Blocks:

82503

Attachments:

Description	Flags
Patch (v1).	none
Fixing build on various platforms.	none
Patch (V2)	none
Fixing build.	none
Fixing build.	none
Fixing build.	enrica: review+

Jia Pu

Reported 2012-04-02 16:36:26 PDT

These functions are only used on OSX. This change is based on feedback in bug 82503.

Attachments
Patch (v1). (63.40 KB, patch) 2012-04-04 16:52 PDT, Jia Pu	no flags	Details Formatted Diff Diff
Fixing build on various platforms. (61.88 KB, patch) 2012-04-04 17:37 PDT, Jia Pu	no flags	Details Formatted Diff Diff
Patch (V2) (64.78 KB, patch) 2012-04-04 23:05 PDT, Jia Pu	no flags	Details Formatted Diff Diff
Fixing build. (66.42 KB, patch) 2012-04-05 00:10 PDT, Jia Pu	no flags	Details Formatted Diff Diff
Fixing build. (68.05 KB, patch) 2012-04-05 01:06 PDT, Jia Pu	no flags	Details Formatted Diff Diff
Fixing build. (66.75 KB, patch) 2012-04-05 07:00 PDT, Jia Pu	enrica: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Jia Pu

Comment 1 2012-04-02 16:47:19 PDT

<rdar://problem/11170898>

Jia Pu

Comment 2 2012-04-04 16:52:37 PDT

Created attachment 135722 [details] Patch (v1).

Gustavo Noronha (kov)

Comment 3 2012-04-04 17:17:39 PDT

Comment on attachment 135722 [details] Patch (v1). Attachment 135722 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12335027

Jia Pu

Comment 4 2012-04-04 17:37:27 PDT

Created attachment 135730 [details] Fixing build on various platforms.

Philippe Normand

Comment 5 2012-04-04 17:43:14 PDT

Comment on attachment 135730 [details] Fixing build on various platforms. Attachment 135730 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12335045

Build Bot

Comment 6 2012-04-04 18:05:48 PDT

Comment on attachment 135730 [details] Fixing build on various platforms. Attachment 135730 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12335049

Early Warning System Bot

Comment 7 2012-04-04 18:28:09 PDT

Comment on attachment 135730 [details] Fixing build on various platforms. Attachment 135730 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12341064

Jia Pu

Comment 8 2012-04-04 23:05:58 PDT

Created attachment 135760 [details] Patch (V2)

Philippe Normand

Comment 9 2012-04-04 23:16:58 PDT

Comment on attachment 135760 [details] Patch (V2) Attachment 135760 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12335159

Early Warning System Bot

Comment 10 2012-04-04 23:25:27 PDT

Comment on attachment 135760 [details] Patch (V2) Attachment 135760 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12341164

Build Bot

Comment 11 2012-04-04 23:26:58 PDT

Comment on attachment 135760 [details] Patch (V2) Attachment 135760 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12337157

Jia Pu

Comment 12 2012-04-05 00:10:51 PDT

Created attachment 135767 [details] Fixing build.

WebKit Review Bot

Comment 13 2012-04-05 00:14:15 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Early Warning System Bot

Comment 14 2012-04-05 00:28:12 PDT

Comment on attachment 135767 [details] Fixing build. Attachment 135767 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12336174

Build Bot

Comment 15 2012-04-05 00:36:18 PDT

Comment on attachment 135767 [details] Fixing build. Attachment 135767 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12337177

Jia Pu

Comment 16 2012-04-05 01:06:22 PDT

Created attachment 135776 [details] Fixing build.

Early Warning System Bot

Comment 17 2012-04-05 01:18:42 PDT

Comment on attachment 135776 [details] Fixing build. Attachment 135776 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12338157

Build Bot

Comment 18 2012-04-05 01:43:10 PDT

Comment on attachment 135776 [details] Fixing build. Attachment 135776 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12340199

Jia Pu

Comment 19 2012-04-05 07:00:31 PDT

Created attachment 135816 [details] Fixing build.

Enrica Casucci

Comment 20 2012-04-05 10:40:06 PDT

Comment on attachment 135816 [details] Fixing build. View in context: https://bugs.webkit.org/attachment.cgi?id=135816&action=review Looks good to me. Please add the null check on the m_frame per my comment above before landing. > Source/WebCore/editing/AlternativeTextController.cpp:473 > + return m_frame->page() ? m_frame->page()->alternativeTextClient() : 0; Should you check also that m_frame is not null?

Jia Pu

Comment 21 2012-04-05 11:18:07 PDT

Committed r113340: <http://trac.webkit.org/changeset/113340>

Note You need to log in before you can comment on or make changes to this bug.