| Summary: | Move correction panel related functions from EditorClient into separated AlternativeTextClient class. | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jia Pu <jiapu.mail> | ||||||||||||||
| Component: | New Bugs | Assignee: | Jia Pu <jiapu.mail> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | cgarcia, gustavo, japhet, menard, mrobinson, pnormand, webkit.review.bot, xan.lopez, zoltan | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | Mac (Intel) | ||||||||||||||||
| OS: | OS X 10.7 | ||||||||||||||||
| Bug Depends on: | 82942 | ||||||||||||||||
| Bug Blocks: | 82503 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Jia Pu
2012-04-02 16:36:26 PDT
Created attachment 135722 [details]
Patch (v1).
Comment on attachment 135722 [details] Patch (v1). Attachment 135722 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12335027 Created attachment 135730 [details]
Fixing build on various platforms.
Comment on attachment 135730 [details] Fixing build on various platforms. Attachment 135730 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12335045 Comment on attachment 135730 [details] Fixing build on various platforms. Attachment 135730 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12335049 Comment on attachment 135730 [details] Fixing build on various platforms. Attachment 135730 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12341064 Created attachment 135760 [details]
Patch (V2)
Comment on attachment 135760 [details] Patch (V2) Attachment 135760 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12335159 Comment on attachment 135760 [details] Patch (V2) Attachment 135760 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12341164 Comment on attachment 135760 [details] Patch (V2) Attachment 135760 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12337157 Created attachment 135767 [details]
Fixing build.
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 135767 [details] Fixing build. Attachment 135767 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12336174 Comment on attachment 135767 [details] Fixing build. Attachment 135767 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12337177 Created attachment 135776 [details]
Fixing build.
Comment on attachment 135776 [details] Fixing build. Attachment 135776 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12338157 Comment on attachment 135776 [details] Fixing build. Attachment 135776 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12340199 Created attachment 135816 [details]
Fixing build.
Comment on attachment 135816 [details] Fixing build. View in context: https://bugs.webkit.org/attachment.cgi?id=135816&action=review Looks good to me. Please add the null check on the m_frame per my comment above before landing. > Source/WebCore/editing/AlternativeTextController.cpp:473 > + return m_frame->page() ? m_frame->page()->alternativeTextClient() : 0; Should you check also that m_frame is not null? Committed r113340: <http://trac.webkit.org/changeset/113340> |