Summary: | styleForElement() should use enums instead of bools so we can all understand what it's doing | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, hyatt, macpherson, menard, simon.fraser, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 45950 | ||||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2012-03-30 16:54:52 PDT
Created attachment 134915 [details]
Patch
Comment on attachment 134915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134915&action=review > Source/WebCore/rendering/RenderObject.cpp:2548 > + /// FIXME: This "find nearest element parent" should be a helper function. /////////////////// Attachment 134915 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSStyleSelector.cpp:1570: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style. Created attachment 134916 [details]
Patch for landing
Comment on attachment 134916 [details] Patch for landing Rejecting attachment 134916 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: eSelector.h patching file Source/WebCore/css/MediaQueryMatcher.cpp patching file Source/WebCore/css/StyleMedia.cpp patching file Source/WebCore/dom/Element.cpp patching file Source/WebCore/rendering/RenderObject.cpp Hunk #1 succeeded at 2560 (offset 15 lines). patching file Source/WebCore/rendering/RenderRegion.cpp patching file Source/WebCore/svg/SVGElement.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12267531 Created attachment 134928 [details]
Patch for landing
Attachment 134928 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSStyleSelector.cpp:1570: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style. Comment on attachment 134928 [details] Patch for landing Clearing flags on attachment: 134928 Committed r112765: <http://trac.webkit.org/changeset/112765> All reviewed patches have been landed. Closing bug. |