Summary: | [EFL] DRT should support LayoutTestController's willSendRequestReturnsNullOnRedirect() | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 81891, 84129 | ||||||||||||||
Bug Blocks: | 85072 | ||||||||||||||
Attachments: |
|
Description
Chris Dumez
2012-03-30 01:29:22 PDT
Created attachment 134762 [details]
Proposed patch
Comment on attachment 134762 [details]
Proposed patch
Could you rebase and upload this? It looks the patch was uploaded in unfortunate timing by which bot didn't pick the patch.
Created attachment 139424 [details]
Patch
Rebase on master.
Created attachment 139757 [details]
Patch
Rebase on master.
Comment on attachment 139757 [details]
Patch
Makes sense.
Comment on attachment 139757 [details] Patch Rejecting attachment 139757 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: #1 FAILED at 290. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/efl/test_expectations.txt.rej patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp Hunk #1 succeeded at 432 (offset 3 lines). Hunk #2 succeeded at 442 (offset 3 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12514166 Created attachment 140159 [details]
Patch for landing
Created attachment 140160 [details]
Patch for landing
Add the reviewer name to the changelogs, my bad.
Comment on attachment 140160 [details] Patch for landing Clearing flags on attachment: 140160 Committed r116071: <http://trac.webkit.org/changeset/116071> All reviewed patches have been landed. Closing bug. |