Bug 82704

Summary: [EFL] DRT should support LayoutTestController's willSendRequestReturnsNullOnRedirect()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 81891, 84129    
Bug Blocks: 85072    
Attachments:
Description Flags
Proposed patch
morrita: review-
Patch
none
Patch
tonikitoo: review+, webkit.review.bot: commit-queue-
Patch for landing
none
Patch for landing none

Chris Dumez
Reported 2012-03-30 01:29:22 PDT
EFL's DRT should support LayoutTestController's willSendRequestReturnsNullOnRedirect().
Attachments
Proposed patch (1.43 KB, patch)
2012-03-30 03:06 PDT, Chris Dumez 		morrita: review-
DetailsFormatted DiffDiff
Patch (4.25 KB, patch)
2012-04-30 01:12 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.12 KB, patch)
2012-05-02 00:02 PDT, Chris Dumez 		tonikitoo: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (4.33 KB, patch)
2012-05-03 22:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.33 KB, patch)
2012-05-03 22:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-03-30 03:06:56 PDT
Created attachment 134762 [details] Proposed patch
Hajime Morrita
Comment 2 2012-04-10 18:06:47 PDT
Comment on attachment 134762 [details] Proposed patch Could you rebase and upload this? It looks the patch was uploaded in unfortunate timing by which bot didn't pick the patch.
Chris Dumez
Comment 3 2012-04-30 01:12:33 PDT
Created attachment 139424 [details] Patch Rebase on master.
Chris Dumez
Comment 4 2012-05-02 00:02:40 PDT
Created attachment 139757 [details] Patch Rebase on master.
Raphael Kubo da Costa (:rakuco)
Comment 5 2012-05-02 09:53:49 PDT
Comment on attachment 139757 [details] Patch Makes sense.
WebKit Review Bot
Comment 6 2012-05-03 10:56:37 PDT
Comment on attachment 139757 [details] Patch Rejecting attachment 139757 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: #1 FAILED at 290. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/efl/test_expectations.txt.rej patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp Hunk #1 succeeded at 432 (offset 3 lines). Hunk #2 succeeded at 442 (offset 3 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12514166
Chris Dumez
Comment 7 2012-05-03 22:32:54 PDT
Created attachment 140159 [details] Patch for landing
Chris Dumez
Comment 8 2012-05-03 22:40:03 PDT
Created attachment 140160 [details] Patch for landing Add the reviewer name to the changelogs, my bad.
WebKit Review Bot
Comment 9 2012-05-03 23:24:01 PDT
Comment on attachment 140160 [details] Patch for landing Clearing flags on attachment: 140160 Committed r116071: <http://trac.webkit.org/changeset/116071>
WebKit Review Bot
Comment 10 2012-05-03 23:24:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.