Bug 82704

Summary: [EFL] DRT should support LayoutTestController's willSendRequestReturnsNullOnRedirect()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 81891, 84129    
Bug Blocks: 85072    
Description Flags
Proposed patch
morrita: review-
tonikitoo: review+, webkit.review.bot: commit-queue-
Patch for landing
Patch for landing none

Description Chris Dumez 2012-03-30 01:29:22 PDT
EFL's DRT should support LayoutTestController's willSendRequestReturnsNullOnRedirect().
Comment 1 Chris Dumez 2012-03-30 03:06:56 PDT
Created attachment 134762 [details]
Proposed patch
Comment 2 Hajime Morrita 2012-04-10 18:06:47 PDT
Comment on attachment 134762 [details]
Proposed patch

Could you rebase and upload this? It looks the patch was uploaded in unfortunate timing by which bot didn't pick the patch.
Comment 3 Chris Dumez 2012-04-30 01:12:33 PDT
Created attachment 139424 [details]

Rebase on master.
Comment 4 Chris Dumez 2012-05-02 00:02:40 PDT
Created attachment 139757 [details]

Rebase on master.
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-05-02 09:53:49 PDT
Comment on attachment 139757 [details]

Makes sense.
Comment 6 WebKit Review Bot 2012-05-03 10:56:37 PDT
Comment on attachment 139757 [details]

Rejecting attachment 139757 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
#1 FAILED at 290.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/efl/test_expectations.txt.rej
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp
Hunk #1 succeeded at 432 (offset 3 lines).
Hunk #2 succeeded at 442 (offset 3 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12514166
Comment 7 Chris Dumez 2012-05-03 22:32:54 PDT
Created attachment 140159 [details]
Patch for landing
Comment 8 Chris Dumez 2012-05-03 22:40:03 PDT
Created attachment 140160 [details]
Patch for landing

Add the reviewer name to the changelogs, my bad.
Comment 9 WebKit Review Bot 2012-05-03 23:24:01 PDT
Comment on attachment 140160 [details]
Patch for landing

Clearing flags on attachment: 140160

Committed r116071: <http://trac.webkit.org/changeset/116071>
Comment 10 WebKit Review Bot 2012-05-03 23:24:07 PDT
All reviewed patches have been landed.  Closing bug.