Summary: | [EFL] LayoutTestController needs implementation of addUserStyleSheet | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sudarsana Nagineni (babu) <naginenis> | ||||||
Component: | WebKit EFL | Assignee: | Sudarsana Nagineni (babu) <naginenis> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 82449 | ||||||||
Attachments: |
|
Description
Sudarsana Nagineni (babu)
2012-03-28 03:39:41 PDT
Created attachment 134259 [details]
Patch
Add addUserStyleSheet implementation
Comment on attachment 134259 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134259&action=review > Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h:68 > + static void addUserStyleSheet(Evas_Object* ewkView, const char* sourceCode, bool allFrames); In my humble opinion, it is better to add const keyword in front of Evas_Object. Because EWKPrivate::corePage is defined as below, http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_private.h#L95 In addition, you just use page object without ewkView's change. It seems you can add const keyword. (In reply to comment #2) > In my humble opinion, it is better to add const keyword in front of Evas_Object. Because EWKPrivate::corePage is defined as below, > http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_private.h#L95 > > In addition, you just use page object without ewkView's change. It seems you can add const keyword. Okay, thanks for your review! Created attachment 134511 [details] Patch fix review comment #2 Comment on attachment 134511 [details]
Patch
Looks good to me.
Comment on attachment 134511 [details] Patch Clearing flags on attachment: 134511 Committed r113719: <http://trac.webkit.org/changeset/113719> All reviewed patches have been landed. Closing bug. |