Bug 82262

Summary: [chromium] Replicas should be included in the computed occlusion
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: backer, cc-bugs, enne, jamesr, piman, reveman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 81227    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Dana Jansens
Reported 2012-03-26 16:57:17 PDT
[chromium] Replicas should be included in the computed occlusion
Attachments
Patch (7.64 KB, patch)
2012-03-26 20:10 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (9.32 KB, patch)
2012-04-09 19:28 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (13.73 KB, patch)
2012-04-09 20:29 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-03-26 20:10:28 PDT
Created attachment 133966 [details] Patch
Adrienne Walker
Comment 2 2012-03-27 10:45:25 PDT
Comment on attachment 133966 [details] Patch Looks good. Thanks as always for the tests. Can you put up a rebaselined patch?
Dana Jansens
Comment 3 2012-03-27 10:52:31 PDT
Thanks, yup! Once bug #81227 is in I'll rebase this and throw it at EWS.
Dana Jansens
Comment 4 2012-04-09 19:28:59 PDT
Created attachment 136376 [details] Patch Trashing your R+ cuz I am adding hasReplica() to RenderSurfaceChromium, and cuz you had asked for a rebased patch and I hadn't done that yet. The diff here is just adding RSChromium::hasReplica() for the templated functions in CCOcclusionTracker
Dana Jansens
Comment 5 2012-04-09 19:32:58 PDT
Comment on attachment 136376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136376&action=review > Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.cpp:129 > + transformedRegion.unite(intersection(surface->clipRect(), enclosedIntRect(transform.mapRect(FloatRect(rects[i]))))); Oh this is wrong, need to check clipRect().isEmpty() first for a surface.
Dana Jansens
Comment 6 2012-04-09 20:29:49 PDT
Created attachment 136386 [details] Patch
Adrienne Walker
Comment 7 2012-04-13 18:06:04 PDT
Comment on attachment 136386 [details] Patch Looks good to me.
WebKit Review Bot
Comment 8 2012-04-13 18:58:40 PDT
Comment on attachment 136386 [details] Patch Clearing flags on attachment: 136386 Committed r114197: <http://trac.webkit.org/changeset/114197>
WebKit Review Bot
Comment 9 2012-04-13 18:58:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.