| Summary: | Add a notification function for detaching to TextFieldDecorator | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
| Component: | Forms | Assignee: | Kent Tamura <tkent> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dglazkov, morrita, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 80479, 82143 | ||||||
| Attachments: |
|
||||||
|
Description
Kent Tamura
2012-03-25 03:45:02 PDT
Created attachment 133676 [details]
Patch
Comment on attachment 133676 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133676&action=review ok. > Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:68 > +inline HTMLInputElement* TextFieldDecorationElement::hostInput() > +{ > + ASSERT(shadowAncestorNode()); > + ASSERT(shadowAncestorNode()->hasTagName(inputTag)); > + return static_cast<HTMLInputElement*>(shadowAncestorNode()); > +} We usually put these into the header, right? Comment on attachment 133676 [details] Patch Clearing flags on attachment: 133676 Committed r112109: <http://trac.webkit.org/changeset/112109> All reviewed patches have been landed. Closing bug. Comment on attachment 133676 [details] Patch Thank you for reviewing! View in context: https://bugs.webkit.org/attachment.cgi?id=133676&action=review >> Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:68 >> +} > > We usually put these into the header, right? I don't think we should do it in this case because - This function is private. - We need to include HTMLInputElement.h and HTMLNames.h to implement this function. |