Bug 81640

Summary: Make animVal support type-safe
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, zherczeg, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 12437    
Bug Blocks: 41761    
Attachments:
Description Flags
Patch koivisto: review+

Nikolas Zimmermann
Reported 2012-03-20 02:18:59 PDT
As discussed with Antti, we should remove SVGGenericAnimatedType, and the associated reinterpret_cast, and replace it with a type-safe solution, even if it requires some boilerplate code. It was a poor decision to go with it initially, so I'm going to redesign it.
Attachments
Patch (73.99 KB, patch)
2012-03-20 04:18 PDT, Nikolas Zimmermann 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2012-03-20 04:18:19 PDT
Created attachment 132794 [details] Patch
Antti Koivisto
Comment 2 2012-03-20 04:41:49 PDT
Comment on attachment 132794 [details] Patch r=me, with naming consistency fixes discussed in irc
Nikolas Zimmermann
Comment 3 2012-03-20 04:47:46 PDT
Committed r111380: <http://trac.webkit.org/changeset/111380>
Note You need to log in before you can comment on or make changes to this bug.