Bug 81552

Summary: [chromium] Push culled tiles that are prepainted
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: backer, cc-bugs, enne, jamesr, piman, reveman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 81529    
Bug Blocks:    
Attachments:
Description Flags
Patch
enne: review+
Patch
none
Patch none

Dana Jansens
Reported 2012-03-19 13:32:11 PDT
[chromium] Push culled tiles that are prepainted
Attachments
Patch (5.68 KB, patch)
2012-03-19 13:34 PDT, Dana Jansens 		enne: review+
DetailsFormatted DiffDiff
Patch (7.51 KB, patch)
2012-03-19 14:55 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (7.41 KB, patch)
2012-03-19 17:53 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-03-19 13:34:08 PDT
Created attachment 132652 [details] Patch
Dana Jansens
Comment 2 2012-03-19 13:49:05 PDT
To be clear, during an idle paint, we still attempt to VisiblePaint, which would mark the tile culled. Then even though we would actually idle-paint the tile, we would not push it to the impl thread.
Dana Jansens
Comment 3 2012-03-19 14:55:01 PDT
Created attachment 132678 [details] Patch
Dana Jansens
Comment 4 2012-03-19 14:56:13 PDT
Comment on attachment 132652 [details] Patch Fix this up a bit. I want a tile to be marked as "updated" ie not culled if it was updated on any pass through prepareToUpdateTiles. Previous version depended on the fact that PaintVisible culled and PaintIdle did not, this one is more robust.
Adrienne Walker
Comment 5 2012-03-19 17:19:17 PDT
Comment on attachment 132652 [details] Patch Looks good to me.
Adrienne Walker
Comment 6 2012-03-19 17:27:40 PDT
Comment on attachment 132678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132678&action=review I like this one better too. One small nit: > Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp:-432 > - tile->m_updateCulled = true; Can you add an assert(!tile->m_updated) here, since this would cause issues if m_updateRect got touched but somehow m_updated was true?
Dana Jansens
Comment 7 2012-03-19 17:42:46 PDT
Comment on attachment 132678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132678&action=review >> Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp:-432 >> - tile->m_updateCulled = true; > > Can you add an assert(!tile->m_updated) here, since this would cause issues if m_updateRect got touched but somehow m_updated was true? Yeh, great plan. Thanks.
Dana Jansens
Comment 8 2012-03-19 17:53:04 PDT
Created attachment 132737 [details] Patch
WebKit Review Bot
Comment 9 2012-03-19 20:11:01 PDT
Comment on attachment 132737 [details] Patch Clearing flags on attachment: 132737 Committed r111335: <http://trac.webkit.org/changeset/111335>
WebKit Review Bot
Comment 10 2012-03-19 20:11:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.