Bug 81536

Summary: [BlackBerry] speed up text selection for large selections
Product: WebKit Reporter: tabbott
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: tonikitoo, webkit.review.bot
Priority: P2    
Version: 525.x (Safari 3.2)   
Hardware: Other   
OS: Other   
Bug Depends on: 82650    
Bug Blocks:    
Attachments:
Description Flags
fast patch
rwlbuis: review-, rwlbuis: commit-queue+
extra prefixes removed none

Description tabbott 2012-03-19 12:15:21 PDT 
Doing a selectAll on http://en.wikipedia.org/wiki/Albert_Einstein takes more than one second (1.395534s). Most of the time is spent creating the consolidated IntRectRegion.
Comment 1 tabbott 2012-03-19 12:44:11 PDT 
Internal PR 136593
Comment 2 tabbott 2012-03-19 14:00:53 PDT 
Created attachment 132662 [details]
fast patch
Comment 3 Rob Buis 2012-03-19 14:09:01 PDT 
Comment on attachment 132662 [details]
fast patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132662&action=review

Can fix some prefixes.

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:118
> +        BlackBerry::Platform::IntRect selectionBoundingBox;

Probably don't need the BlackBerry prefix.
Comment 4 tabbott 2012-03-19 14:10:29 PDT 
Created attachment 132666 [details]
extra prefixes removed
Comment 5 Rob Buis 2012-03-19 14:13:06 PDT 
Comment on attachment 132666 [details]
extra prefixes removed

LGTM.
Comment 6 WebKit Review Bot 2012-03-19 15:17:50 PDT 
Comment on attachment 132666 [details]
extra prefixes removed

Clearing flags on attachment: 132666

Committed r111259: <http://trac.webkit.org/changeset/111259>
Comment 7 WebKit Review Bot 2012-03-19 15:17:55 PDT 
All reviewed patches have been landed.  Closing bug.