Summary: | [chromium] Invalidate/update evicted tiles during commit | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dana Jansens <danakj> | ||||||||
Component: | New Bugs | Assignee: | Dana Jansens <danakj> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | backer, cc-bugs, enne, jamesr, piman, reveman, shawnsingh, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 81552 | ||||||||||
Attachments: |
|
Description
Dana Jansens
2012-03-19 11:25:30 PDT
Created attachment 132614 [details]
Patch
Attachment 132614 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:12: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 132617 [details]
Patch
Comment on attachment 132617 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132617&action=review Sorry for not catching this issue the first time through review. > Source/WebKit/chromium/tests/TiledLayerChromiumTest.cpp:370 > + EXPECT_TRUE(layerImpl->hasTileAt(0, 0)); > + EXPECT_FALSE(layerImpl->hasTileAt(0, 1)); Can you also verify after a pushPropertiesTo that neither tile is there? I don't think we have any test related to that. (In reply to comment #4) > (From update of attachment 132617 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=132617&action=review > > Sorry for not catching this issue the first time through review. > > > Source/WebKit/chromium/tests/TiledLayerChromiumTest.cpp:370 > > + EXPECT_TRUE(layerImpl->hasTileAt(0, 0)); > > + EXPECT_FALSE(layerImpl->hasTileAt(0, 1)); > > Can you also verify after a pushPropertiesTo that neither tile is there? I don't think we have any test related to that. ...before doing any painting, I mean. Created attachment 132644 [details]
Patch
Thanks! Done!
Comment on attachment 132644 [details] Patch Clearing flags on attachment: 132644 Committed r111253: <http://trac.webkit.org/changeset/111253> All reviewed patches have been landed. Closing bug. |