Bug 81481

Summary: webkitdirs.pm: Make determineNumberOfCPUs work on FreeBSD.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: Tools / TestsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, gustavo, jchaffraix, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Raphael Kubo da Costa (:rakuco)
Reported 2012-03-18 20:00:36 PDT
webkitdirs.pm: Make determineNumberOfCPUs work on FreeBSD.
Attachments
Patch (1.54 KB, patch)
2012-03-18 20:01 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Patch (1.61 KB, patch)
2012-03-18 20:14 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-03-18 20:01:07 PDT
Created attachment 132528 [details] Patch
WebKit Review Bot
Comment 2 2012-03-18 20:06:07 PDT
Attachment 132528 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitdi..." exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-03-18 20:14:08 PDT
Created attachment 132531 [details] Patch
Martin Robinson
Comment 4 2012-03-19 19:08:21 PDT
Comment on attachment 132531 [details] Patch Sorry. Removing r+ flag, because of Adam's comments here: https://bugs.webkit.org/show_bug.cgi?id=81465
Julien Chaffraix
Comment 5 2012-04-19 16:02:17 PDT
Comment on attachment 132531 [details] Patch Looks sane (if it still applies).
Julien Chaffraix
Comment 6 2012-04-19 16:14:56 PDT
Comment on attachment 132531 [details] Patch Clearing r+ again pending the missing discussion (missed abarth & mrobinson comments, my apologies for the noise)
WebKit Review Bot
Comment 7 2012-05-07 16:14:16 PDT
Comment on attachment 132531 [details] Patch Clearing flags on attachment: 132531 Committed r116366: <http://trac.webkit.org/changeset/116366>
WebKit Review Bot
Comment 8 2012-05-07 16:14:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.