| Summary: | webkitdirs.pm: Make determineNumberOfCPUs work on FreeBSD. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||||
| Component: | Tools / Tests | Assignee: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, gustavo, jchaffraix, mrobinson, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Raphael Kubo da Costa (:rakuco)
2012-03-18 20:00:36 PDT
Created attachment 132528 [details]
Patch
Attachment 132528 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitdi..." exit_code: 1
Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 132531 [details]
Patch
Comment on attachment 132531 [details] Patch Sorry. Removing r+ flag, because of Adam's comments here: https://bugs.webkit.org/show_bug.cgi?id=81465 Comment on attachment 132531 [details]
Patch
Looks sane (if it still applies).
Comment on attachment 132531 [details]
Patch
Clearing r+ again pending the missing discussion (missed abarth & mrobinson comments, my apologies for the noise)
Comment on attachment 132531 [details] Patch Clearing flags on attachment: 132531 Committed r116366: <http://trac.webkit.org/changeset/116366> All reviewed patches have been landed. Closing bug. |