Bug 81465 - VCSUtils.pm: Prefer "gpatch" over "patch" when it is available.
Summary: VCSUtils.pm: Prefer "gpatch" over "patch" when it is available.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-17 22:09 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2012-05-03 18:50 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.56 KB, patch)
2012-03-17 22:11 PDT, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Patch (5.35 KB, patch)
2012-03-17 22:21 PDT, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Patch (5.39 KB, patch)
2012-03-17 22:23 PDT, Raphael Kubo da Costa (:rakuco)
abarth: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-03-17 22:09:05 PDT
VCUtils.pm: Prefer "gpatch" over "patch" when it is available.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-03-17 22:11:23 PDT
Created attachment 132480 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-03-17 22:21:02 PDT
Created attachment 132481 [details]
Patch
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-03-17 22:23:15 PDT
Created attachment 132482 [details]
Patch
Comment 4 Adam Barth 2012-03-19 00:31:36 PDT
Comment on attachment 132482 [details]
Patch

Before we start landing patches like this, we should have a more general discussion on webkit-dev about whether we're going to support FreeBSD and which ports want this support.
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-05-03 18:50:27 PDT
I think it makes sense to close this. There is no standardization around "alternative names" for the patch binary, so "gpatch" can be considered an arbitrary name which works on a certain OS.

Symlinking gpatch to patch in a directory and prepending it to $PATH has the same effect.