Bug 81481 - webkitdirs.pm: Make determineNumberOfCPUs work on FreeBSD.
Summary: webkitdirs.pm: Make determineNumberOfCPUs work on FreeBSD.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-18 20:00 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2012-05-07 16:14 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2012-03-18 20:01 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2012-03-18 20:14 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-03-18 20:00:36 PDT 
webkitdirs.pm: Make determineNumberOfCPUs work on FreeBSD.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-03-18 20:01:07 PDT 
Created attachment 132528 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-18 20:06:07 PDT 
Attachment 132528 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitdi..." exit_code: 1
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-03-18 20:14:08 PDT 
Created attachment 132531 [details]
Patch
Comment 4 Martin Robinson 2012-03-19 19:08:21 PDT 
Comment on attachment 132531 [details]
Patch

Sorry. Removing r+ flag, because of Adam's comments here:  https://bugs.webkit.org/show_bug.cgi?id=81465
Comment 5 Julien Chaffraix 2012-04-19 16:02:17 PDT 
Comment on attachment 132531 [details]
Patch

Looks sane (if it still applies).
Comment 6 Julien Chaffraix 2012-04-19 16:14:56 PDT 
Comment on attachment 132531 [details]
Patch

Clearing r+ again pending the missing discussion (missed abarth & mrobinson comments, my apologies for the noise)
Comment 7 WebKit Review Bot 2012-05-07 16:14:16 PDT 
Comment on attachment 132531 [details]
Patch

Clearing flags on attachment: 132531

Committed r116366: <http://trac.webkit.org/changeset/116366>
Comment 8 WebKit Review Bot 2012-05-07 16:14:21 PDT 
All reviewed patches have been landed.  Closing bug.