Bug 81333

Summary: MediaStream API (JSEP): Introducing PeerConnection00Handler
Product: WebKit Reporter: Tommy Widenflycht <tommyw@google.com>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw@google.com>
Status: RESOLVED FIXED    
Severity: Normal CC: harald@alvestrand.no, pkasting@google.com, webkit.review.bot@gmail.com
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 81377    
Bug Blocks: 80589    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description From 2012-03-16 04:47:35 PST
In preparation of the last WebCore patch that will introduce PeerConnection00 here's its platform representation.
------- Comment #1 From 2012-03-16 04:52:29 PST -------
Created an attachment (id=132251) [details]
Patch
------- Comment #2 From 2012-03-16 06:13:19 PST -------
Created an attachment (id=132266) [details]
Patch
------- Comment #3 From 2012-03-16 06:50:04 PST -------
(From update of attachment 132266 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=132266&action=review

> Source/WebCore/platform/mediastream/PeerConnection00Handler.cpp:65
> +PassRefPtr<SessionDescriptionDescriptor> PeerConnection00Handler::createAnswer(const String& offer, PassRefPtr<MediaHints>)

You might need to add UNUSED_PARAM(offer) for some ports.
------- Comment #4 From 2012-03-16 06:58:00 PST -------
(From update of attachment 132266 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=132266&action=review

>> Source/WebCore/platform/mediastream/PeerConnection00Handler.cpp:65
>> +PassRefPtr<SessionDescriptionDescriptor> PeerConnection00Handler::createAnswer(const String& offer, PassRefPtr<MediaHints>)
> 
> You might need to add UNUSED_PARAM(offer) for some ports.

I'll just remove all argument names , these are just dummy implementations after all. OK?
------- Comment #5 From 2012-03-16 07:08:38 PST -------
Created an attachment (id=132276) [details]
Patch
------- Comment #6 From 2012-03-16 09:57:19 PST -------
(From update of attachment 132276 [details])
Clearing flags on attachment: 132276

Committed r111020: <http://trac.webkit.org/changeset/111020>
------- Comment #7 From 2012-03-16 09:57:23 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #8 From 2012-03-16 11:21:19 PST -------
This broke Chromium Win compile: http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/24486/steps/compile-webkit/logs/stdio

tommyw and abarth don't seem to be around, I plan to roll out and reopen.
------- Comment #9 From 2012-03-16 11:34:05 PST -------
Rolled out in r111035.
------- Comment #10 From 2012-03-19 06:56:18 PST -------
Created an attachment (id=132570) [details]
Patch
------- Comment #11 From 2012-03-19 06:58:55 PST -------
Hopefully fixed build break by adding the necessary headers to Source/WebCore/platform/mediastream/PeerConnection00Handler.cpp

Strange that all other compilers optimized away the unused references, but windows failed.
------- Comment #12 From 2012-03-19 11:10:23 PST -------
(From update of attachment 132570 [details])
Ok.
------- Comment #13 From 2012-03-19 11:33:38 PST -------
(From update of attachment 132570 [details])
Clearing flags on attachment: 132570

Committed r111208: <http://trac.webkit.org/changeset/111208>
------- Comment #14 From 2012-03-19 11:33:42 PST -------
All reviewed patches have been landed.  Closing bug.