Bug 81222

Summary: [chromium] Changes to overdraw metrics to allow upload tracking
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: backer, cc-bugs, enne, jamesr, piman, reveman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 81156    
Bug Blocks: 81175, 81242    
Attachments:
Description Flags
Patch
none
Patch none

Dana Jansens
Reported 2012-03-15 08:11:02 PDT
[chromium] Changes to overdraw metrics to all upload tracking
Attachments
Patch (37.42 KB, patch)
2012-03-15 08:19 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (37.52 KB, patch)
2012-03-15 17:51 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-03-15 08:19:18 PDT
Created attachment 132054 [details] Patch
Adrienne Walker
Comment 2 2012-03-15 13:23:44 PDT
Comment on attachment 132054 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132054&action=review R=me. It makes sense to rename painting to upload, since we may paint much more if we're not using per-tile painting. > Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.h:113 > + OwnPtr<CCOverdrawMetrics> m_overdrawMetrics; nit: Maybe make this a local, since you always create it and return a reference to it?
Dana Jansens
Comment 3 2012-03-15 13:25:01 PDT
Comment on attachment 132054 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132054&action=review Thanks! >> Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.h:113 >> + OwnPtr<CCOverdrawMetrics> m_overdrawMetrics; > > nit: Maybe make this a local, since you always create it and return a reference to it? I agree, but then I can't pass a const CCOcclusionTracker around to culling. WDYT is better?
Adrienne Walker
Comment 4 2012-03-15 13:36:38 PDT
Comment on attachment 132054 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132054&action=review >>> Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.h:113 >>> + OwnPtr<CCOverdrawMetrics> m_overdrawMetrics; >> >> nit: Maybe make this a local, since you always create it and return a reference to it? > > I agree, but then I can't pass a const CCOcclusionTracker around to culling. WDYT is better? Ah, I see. What's in the patch seems reasonable given that.
Dana Jansens
Comment 5 2012-03-15 17:51:24 PDT
Created attachment 132164 [details] Patch
WebKit Review Bot
Comment 6 2012-03-16 02:20:45 PDT
Comment on attachment 132164 [details] Patch Clearing flags on attachment: 132164 Committed r110973: <http://trac.webkit.org/changeset/110973>
WebKit Review Bot
Comment 7 2012-03-16 02:20:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.