Bug 81219

Summary:

Enable animVal support for SVGNumberList

Product:

WebKit

Reporter:

Nikolas Zimmermann <zimmermann>

Component:

SVG

Assignee:

Nikolas Zimmermann <zimmermann>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

12437

Bug Blocks:

41761

Attachments:

Description	Flags
Patch	rwlbuis: review+

Description Nikolas Zimmermann 2012-03-15 07:29:09 PDT

Enable animVal support for SVGNumberList.
Easy patch, as all ground-work is done.

Comment 1 Nikolas Zimmermann 2012-03-15 07:45:29 PDT

Created attachment 132045 [details]
Patch

Comment 2 Rob Buis 2012-03-15 07:56:37 PDT

Comment on attachment 132045 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132045&action=review

LGTM.

> Source/WebCore/svg/SVGAnimatedNumberList.h:49
> +    virtual PassOwnPtr<SVGAnimatedType> constructFromCopy(SVGGenericAnimatedType*);

As discussed on irc, constructFromVariant may be a better name.

Comment 3 Nikolas Zimmermann 2012-03-15 08:28:19 PDT

Committed r110848: <http://trac.webkit.org/changeset/110848>