| Summary: | [chromium] Move overdraw metrics into a templated class for both paint and draw metrics. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dana Jansens <danakj> | ||||||||
| Component: | New Bugs | Assignee: | Dana Jansens <danakj> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | backer, cc-bugs, enne, jamesr, nduca, piman, reveman, webkit.review.bot, wjmaclean | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 81175, 81222 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dana Jansens
2012-03-14 13:56:49 PDT
Created attachment 131919 [details]
Patch
(Also adds TRACE_COUNTER_ID1 for the non-normalized values) Comment on attachment 131919 [details]
Patch
We have TRACE_COUNTER_ID2 where you can do stuff like "bytesAllocated,bytesFree" and get both into a single counter. Can we pile this into there so we have 1 counter rather than 3? If we need support for 3-value counters, its all supported and we just need to add it to the trace_event macros .... jbates can help there.
(In reply to comment #3) > (From update of attachment 131919 [details]) > We have TRACE_COUNTER_ID2 where you can do stuff like "bytesAllocated,bytesFree" and get both into a single counter. Can we pile this into there so we have 1 counter rather than 3? If we need support for 3-value counters, its all supported and we just need to add it to the trace_event macros .... jbates can help there. Yep, done! Created attachment 131933 [details]
Patch
Created attachment 131951 [details]
Patch
Using a single event to record both opaque/translucent pixel counts. Tested this out with about:tracing and it seems pretty reasonable, you can drill in and find pixel counts when you need to, until something better in the about:tracing system comes along.
Comment on attachment 131951 [details]
Patch
R=me. Why counter+event rather than three counters? That seems reasonable too, but I'm just curious why the change?
(In reply to comment #7) > (From update of attachment 131951 [details]) > R=me. Why counter+event rather than three counters? That seems reasonable too, but I'm just curious why the change? Nat was concerned about too many bars on about:tracing. Comment on attachment 131951 [details] Patch Clearing flags on attachment: 131951 Committed r110921: <http://trac.webkit.org/changeset/110921> All reviewed patches have been landed. Closing bug. |