Bug 81111

Summary: Move EntryArray, EntryBase, EntryCallback, and Entry to Modules/filesystem/
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: abarth, dglazkov, ojan, rakuco, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2012-03-14 08:17:15 PDT
Move EntryArray, EntryBase, EntryCallback, and Entry to Modules/filesystem/
Attachments
Patch (113.09 KB, patch)
2012-03-14 08:19 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (114.39 KB, patch)
2012-03-15 10:33 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-03-14 08:19:08 PDT
Created attachment 131852 [details] Patch
Build Bot
Comment 2 2012-03-14 08:47:19 PDT
Comment on attachment 131852 [details] Patch Attachment 131852 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11958060
WebKit Review Bot
Comment 3 2012-03-14 09:11:53 PDT
Comment on attachment 131852 [details] Patch Attachment 131852 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11957073
Mark Pilgrim (Google)
Comment 4 2012-03-15 10:33:18 PDT
Created attachment 132074 [details] Patch
WebKit Review Bot
Comment 5 2012-03-15 10:36:09 PDT
Attachment 132074 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/Modules/filesystem/EntryArray.h:51: The parameter name "entry" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/Modules/filesystem/Entry.h:54: The parameter name "errorCallback" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/Modules/filesystem/Entry.h:55: The parameter name "errorCallback" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/Modules/filesystem/Entry.h:56: The parameter name "errorCallback" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/Modules/filesystem/Entry.h:57: The parameter name "errorCallback" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/Modules/filesystem/Entry.h:58: The parameter name "errorCallback" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 6 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 6 2012-03-15 11:07:13 PDT
Comment on attachment 132074 [details] Patch Attachment 132074 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11952907
WebKit Review Bot
Comment 7 2012-03-15 11:34:08 PDT
Comment on attachment 132074 [details] Patch Attachment 132074 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11956706
Mark Pilgrim (Google)
Comment 8 2012-03-16 08:14:03 PDT
*** This bug has been marked as a duplicate of bug 81353 ***
Eric Seidel (no email)
Comment 9 2012-03-20 00:56:11 PDT
Comment on attachment 132074 [details] Patch Cleared review? from attachment 132074 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.