| Summary: | [BlackBerry] Rename the existing WebPageCompositor class to WebPageCompositorPrivate | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Arvid Nilsson <anilsson> | ||||||||
| Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | rakuco, rwlbuis, tonikitoo, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 81099, 81118 | ||||||||||
| Bug Blocks: | 81115 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Arvid Nilsson
2012-03-14 08:01:03 PDT
Created attachment 131849 [details]
Patch
Change component Comment on attachment 131849 [details]
Patch
Looks good. But should the file name change as well to reflect the new class name?
Created attachment 131872 [details]
Patch
(In reply to comment #3) > (From update of attachment 131849 [details]) > Looks good. But should the file name change as well to reflect the new class name? No, it should not. The implementation of a YadaPrivate class will typically be found in Yada.cpp. Yada.h and Yada will be added later (follow the blocks change) I'll have to try again tomorrow, the patch is not coming out right... I must be preparing it for upstream submission the wrong way. Created attachment 132419 [details]
Patch
Comment on attachment 132419 [details]
Patch
LGTM.
Comment on attachment 132419 [details] Patch Clearing flags on attachment: 132419 Committed r111099: <http://trac.webkit.org/changeset/111099> All reviewed patches have been landed. Closing bug. |