Bug 81108

Summary: [BlackBerry] Rename the existing WebPageCompositor class to WebPageCompositorPrivate
Product: WebKit Reporter: Arvid Nilsson <anilsson>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: rakuco, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 81099, 81118    
Bug Blocks: 81115    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Arvid Nilsson
Reported 2012-03-14 08:01:03 PDT
[BlackBerry] Rename the existing WebPageCompositor class to WebPageCompositorPrivate
Attachments
Patch (23.54 KB, patch)
2012-03-14 08:11 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
Patch (23.38 KB, patch)
2012-03-14 09:47 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
Patch (23.21 KB, patch)
2012-03-16 17:09 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Arvid Nilsson
Comment 1 2012-03-14 08:11:18 PDT
Created attachment 131849 [details] Patch
Arvid Nilsson
Comment 2 2012-03-14 08:22:14 PDT
Change component
Rob Buis
Comment 3 2012-03-14 08:25:05 PDT
Comment on attachment 131849 [details] Patch Looks good. But should the file name change as well to reflect the new class name?
Arvid Nilsson
Comment 4 2012-03-14 09:47:05 PDT
Created attachment 131872 [details] Patch
Arvid Nilsson
Comment 5 2012-03-14 09:48:00 PDT
(In reply to comment #3) > (From update of attachment 131849 [details]) > Looks good. But should the file name change as well to reflect the new class name? No, it should not. The implementation of a YadaPrivate class will typically be found in Yada.cpp. Yada.h and Yada will be added later (follow the blocks change)
Arvid Nilsson
Comment 6 2012-03-14 10:10:59 PDT
I'll have to try again tomorrow, the patch is not coming out right... I must be preparing it for upstream submission the wrong way.
Arvid Nilsson
Comment 7 2012-03-16 17:09:23 PDT
Created attachment 132419 [details] Patch
Rob Buis
Comment 8 2012-03-16 17:24:03 PDT
Comment on attachment 132419 [details] Patch LGTM.
WebKit Review Bot
Comment 9 2012-03-16 17:41:34 PDT
Comment on attachment 132419 [details] Patch Clearing flags on attachment: 132419 Committed r111099: <http://trac.webkit.org/changeset/111099>
WebKit Review Bot
Comment 10 2012-03-16 17:41:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.