Bug 80904

Summary: Make ApplicationCacheHost::canCacheInPageCache() non-const.
Product: WebKit Reporter: Gavin Peters <gavinp>
Component: New BugsAssignee: Gavin Peters <gavinp>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gavin Peters
Reported 2012-03-12 15:57:06 PDT
Make ApplicationCacheHost::canCacheInPageCache() non-const.
Attachments
Patch (3.94 KB, patch)
2012-03-12 15:58 PDT, Gavin Peters 		no flags
DetailsFormatted DiffDiff
Patch (3.86 KB, patch)
2012-03-12 16:41 PDT, Gavin Peters 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Peters
Comment 1 2012-03-12 15:58:56 PDT
Created attachment 131432 [details] Patch
Gavin Peters
Comment 2 2012-03-12 16:00:30 PDT
A const pointer to a large object like ApplicationCacheHost is not our standard practice; so remove this (implicit) one. See also https://bugs.webkit.org/show_bug.cgi?id=80898
Alexey Proskuryakov
Comment 3 2012-03-12 16:05:38 PDT
Comment on attachment 131432 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131432&action=review > Source/WebKit/chromium/ChangeLog:14 > + * loader/appcache/ApplicationCacheHost.h: > + (ApplicationCacheHost): I'm not seeing this file in the patch.
Gavin Peters
Comment 4 2012-03-12 16:41:56 PDT
Created attachment 131449 [details] Patch
Gavin Peters
Comment 5 2012-03-12 16:42:33 PDT
Comment on attachment 131449 [details] Patch ap, that's because that file doesn't exist. I've uploaded a new version that fixes that, and I'll cq+ it with your review tomorrow AM.
WebKit Review Bot
Comment 6 2012-03-13 08:19:00 PDT
Comment on attachment 131449 [details] Patch Clearing flags on attachment: 131449 Committed r110564: <http://trac.webkit.org/changeset/110564>
WebKit Review Bot
Comment 7 2012-03-13 08:19:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.