Bug 80623

Summary: Recent changes to chromium.py etc. broke chromium_android.py
Product: WebKit Reporter: Xianzhu Wang <wangxianzhu>
Component: Tools / TestsAssignee: Xianzhu Wang <wangxianzhu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 80642    
Bug Blocks:    
Attachments:
Description Flags
patch none

Xianzhu Wang
Reported 2012-03-08 11:48:55 PST
Dirk made some changes to chromium.py etc. causing some incompatibilities of chromium_android.py, e.g. _start() and cmd_line(), etc. Should change chromium_android.py accordingly.
Attachments
patch (2.33 KB, patch)
2012-03-08 15:14 PST, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xianzhu Wang
Comment 1 2012-03-08 15:14:52 PST
Created attachment 130916 [details] patch
Dirk Pranke
Comment 2 2012-03-08 15:16:11 PST
Comment on attachment 130916 [details] patch Sorry for missing this ... I should've made these changes as part of my other patch :(.
WebKit Review Bot
Comment 3 2012-03-08 20:28:47 PST
Comment on attachment 130916 [details] patch Clearing flags on attachment: 130916 Committed r110258: <http://trac.webkit.org/changeset/110258>
WebKit Review Bot
Comment 4 2012-03-08 20:28:51 PST
All reviewed patches have been landed. Closing bug.
Tony Chang
Comment 5 2012-03-12 09:36:46 PDT
Should we add a unittest for this?
Xianzhu Wang
Comment 6 2012-03-12 09:42:55 PDT
(In reply to comment #5) > Should we add a unittest for this? Agreed. https://bugs.webkit.org/show_bug.cgi?id=80852
Note You need to log in before you can comment on or make changes to this bug.