Summary: | [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D() | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||||||
Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, fishd, kbr, piman, tkent, vangelis, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 80521 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
James Robinson
2012-03-07 11:09:14 PST
Created attachment 130652 [details]
Patch
Created attachment 130654 [details]
Patch
This has to land after https://chromiumcodereview.appspot.com/9623009/, since that's the chromium-side implementation of the new WebViewClient functions. https://chromiumcodereview.appspot.com/9623009/ has to land after http://trac.webkit.org/changeset/110075 rolls into Chromium DEPS since it's a WebKit side caller of the deprecated function. Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. LGTM Comment on attachment 130654 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130654&action=review This looks good but as you've pointed out can't be r+'d yet due to dependencies. One minor nit. > Source/WebKit/chromium/public/WebViewClient.h:116 > + // Creates a graphics context that renders to a the client's WebView. "that renders to the client's" Created attachment 130657 [details]
fix typo
Comment on attachment 130657 [details]
fix typo
R+ in advance
Comment on attachment 130657 [details] fix typo Rejecting attachment 130657 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /chromium/src/WebViewImpl.cpp Hunk #1 FAILED at 3222. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/src/WebViewImpl.cpp.rej patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/chromium/WebViewHost.cpp patching file Tools/DumpRenderTree/chromium/WebViewHost.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Darin Fish..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11892929 Committed r110364: <http://trac.webkit.org/changeset/110364> Committed r110773: <http://trac.webkit.org/changeset/110773> |