Bug 80521

Summary: [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: alokp, fishd, kbr, piman, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 80523    
Attachments:
Description Flags
Patch kbr: review+

James Robinson
Reported 2012-03-07 10:57:33 PST
[chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
Attachments
Patch (8.07 KB, patch)
2012-03-07 11:01 PST, James Robinson 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-03-07 11:01:07 PST
Created attachment 130649 [details] Patch
James Robinson
Comment 2 2012-03-07 11:03:42 PST
I'm planning to deprecate the bool renderDirectlyToWebView parameter from WebViewClient::createGraphicsContext3D() and have the rule be that onscreen contexts are created through WebViewClient and offscreen contexts are created through WebKitPlatformSupport. This is the only caller on the WebKit side. Pepper plugins will continue to share resources with an out-of-band mechanism exposed to chromium code only.
Kenneth Russell
Comment 3 2012-03-07 11:08:43 PST
Comment on attachment 130649 [details] Patch Looks good.
James Robinson
Comment 4 2012-03-07 11:18:35 PST
Committed r110075: <http://trac.webkit.org/changeset/110075>
Note You need to log in before you can comment on or make changes to this bug.