Bug 80492

Summary:

[Qt] Fix the SH4 build after r109834

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Blocker

CC:

abecsi, fu, hausmann, kenneth, loki, oliver, ossy, thouraya.andolsi, webkit.review.bot, zecke, zherczeg

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

80354

Attachments:

Description	Flags
Add MIPS branch(Add,Sub)32 functions	none
fix for sh4 platform	none

Description Csaba Osztrogonác 2012-03-06 22:45:01 PST

http://trac.webkit.org/changeset/109834 broke the ARM/MIPS/SH4
build because their macroassemblers are incomplete.

It is a P1/blocker bug, because now nobody can build trunk WebKit for Qt-ARM (eg. for N9)

Comment 1 Csaba Osztrogonác 2012-03-06 22:50:57 PST

Missing functions from MacroAssemblerARM:
- ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:624:68: error: no matching function for call to 'JSC::JIT::branchAdd32(JSC::MacroAssemblerARM::ResultCondition, const JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID&)'
- ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:738:68: error: no matching function for call to 'JSC::JIT::branchSub32(JSC::MacroAssemblerARM::ResultCondition, const JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID&)'


Missing functions from MacroAssemblerMIPS:
- ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:624:68: error: no matching function for call to 'JSC::JIT::branchAdd32(JSC::MacroAssemblerMIPS::ResultCondition, const JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::RegisterID&)'
- ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:738:68: error: no matching function for call to 'JSC::JIT::branchSub32(JSC::MacroAssemblerMIPS::ResultCondition, const JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::RegisterID&)'

Missing functions from MacroAssemblerSH4:
- ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:624:68: error: no matching function for call to 'JSC::JIT::branchAdd32(JSC::MacroAssemblerSH4::ResultCondition, const JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::SH4Assembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID&)'

- ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:738:68: error: no matching function for call to 'JSC::JIT::branchSub32(JSC::MacroAssemblerSH4::ResultCondition, const JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::SH4Assembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID&)'

Comment 2 Oliver Hunt 2012-03-06 22:53:50 PST

Sigh, I'll hit it with a stick in the morning.

Comment 3 Csaba Osztrogonác 2012-03-06 22:54:50 PST

fu@mips.com, thouraya.andolsi@st.com

Comment 4 Csaba Osztrogonác 2012-03-06 22:56:00 PST

(In reply to comment #3)
> fu@mips.com, thouraya.andolsi@st.com

Oooop, copy/paste error. :) I cc-ed MIPS and SH4 guys too.

Comment 5 Simon Hausmann 2012-03-07 03:31:00 PST

ARM fix landed in http://trac.webkit.org/changeset/110044

Comment 6 Csaba Osztrogonác 2012-03-07 07:09:59 PST

cc Holger too, he might be interested in fixing MIPS and SH4 platforms.

Comment 7 Chao-ying Fu 2012-03-07 17:39:51 PST

Created attachment 130734 [details]
Add MIPS branch(Add,Sub)32 functions

Hi,

  Here is a MIPS patch.  Thanks!

Regards,
Chao-ying

Comment 8 WebKit Review Bot 2012-03-07 22:15:17 PST

Comment on attachment 130734 [details]
Add MIPS branch(Add,Sub)32 functions

Clearing flags on attachment: 130734

Committed r110147: <http://trac.webkit.org/changeset/110147>

Comment 9 WebKit Review Bot 2012-03-07 22:15:22 PST

All reviewed patches have been landed.  Closing bug.

Comment 10 Csaba Osztrogonác 2012-03-08 03:45:02 PST

Reopen to fix SH4 build too.

Comment 11 thouraya 2012-03-08 07:59:27 PST

Created attachment 130822 [details]
fix for sh4 platform

Comment 12 Zoltan Herczeg 2012-03-09 03:44:39 PST

Comment on attachment 130822 [details]
fix for sh4 platform

r=me

Comment 13 WebKit Review Bot 2012-03-09 04:45:36 PST

Comment on attachment 130822 [details]
fix for sh4 platform

Clearing flags on attachment: 130822

Committed r110289: <http://trac.webkit.org/changeset/110289>

Comment 14 WebKit Review Bot 2012-03-09 04:45:47 PST

All reviewed patches have been landed.  Closing bug.