Bug 80257

Summary: Lifecycle of InternalSettings should be simplified.
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: Tools / TestsAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79935    
Attachments:
Description Flags
Patch rniwa: review+

Hajime Morrita
Reported 2012-03-05 02:10:36 PST
InternalSettings::create() is simply crazy. We need to simplify it before it becomes worse.
Attachments
Patch (5.78 KB, patch)
2012-03-05 16:35 PST, Hajime Morrita 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-03-05 16:35:24 PST
Created attachment 130229 [details] Patch
Ryosuke Niwa
Comment 2 2012-03-05 16:40:46 PST
Comment on attachment 130229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130229&action=review rs=me > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=80257 > + Lifecycle of InternalSettings should be simplified. The order is wrong :( > Source/WebCore/testing/InternalSettings.cpp:94 > + , m_passwordEchoDurationInSecondsBackup(settings()->passwordEchoDurationInSeconds()) > + , m_passwordEchoEnabledBackup(settings()->passwordEchoEnabled()) It's better to call these two variables m_originalPasswordEchoDurationInSeconds and m_originalPasswordEchoEnabled to be consistent with similar variables in WebKit.
Hajime Morrita
Comment 3 2012-03-05 16:47:44 PST
Committed r109817: <http://trac.webkit.org/changeset/109817>
Note You need to log in before you can comment on or make changes to this bug.