Bug 80222

Summary:

RetainPtr: Use adoptCF function instead of AdoptCF constructor argument

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Web Template Framework

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, benjamin, cmarcelo, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	ap: review+

Description Darin Adler 2012-03-04 11:53:41 PST

We should change clients of RetainPtr to use the adoptCF function instead of the adoptCF constructor argument. Then we should get rid of the AdoptCF constructor or make it private.

Comment 1 Darin Adler 2013-05-09 18:12:12 PDT

This is mostly done.

Comment 2 Darin Adler 2013-05-27 16:23:08 PDT

Created attachment 203014 [details]
Patch

Comment 3 Darin Adler 2013-05-27 16:23:17 PDT

*** Bug 80223 has been marked as a duplicate of this bug. ***

Comment 4 Darin Adler 2013-05-27 16:31:26 PDT

This will break iOS so I can’t land it until I do some work on the internal code there.

Comment 5 Darin Adler 2014-05-04 17:24:25 PDT

Created attachment 230797 [details]
Patch

Comment 6 WebKit Commit Bot 2014-05-04 17:25:59 PDT

Attachment 230797 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/RetainPtr.h:51:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WTF/wtf/RetainPtr.h:62:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WTF/wtf/RetainPtr.h:107:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 3 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 Darin Adler 2014-05-05 20:13:21 PDT

Committed r168348: <http://trac.webkit.org/changeset/168348>