Summary: | :empty still applies to elements made non-empty via page dynamics | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | noel gordon <noel.gordon> | ||||||||
Component: | CSS | Assignee: | noel gordon <noel.gordon> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | allan.jensen, gpetrioli, joethomas, kling, koivisto, mikelawther, mitz, mjs, webkit, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | 26570 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
noel gordon
2012-02-27 19:05:14 PST
Created attachment 129164 [details]
test case
*** Bug 79730 has been marked as a duplicate of this bug. *** Other browsers tested: Safari 5.1.2 (6534.52.7, 535+) : FAIL Chrome 19.0.1049.3 dev Mac : FAIL Firefox 10.0.2 Mac : OK IE9/10 Win: OK Created attachment 129498 [details]
ProposedPatch
Comment on attachment 129498 [details] ProposedPatch Rejecting attachment 129498 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11770534 Can someone help me to land this patch? It failed at the commit-queue with false error. Done, looks fine this time round. Comment on attachment 129498 [details] ProposedPatch Clearing flags on attachment: 129498 Committed r109417: <http://trac.webkit.org/changeset/109417> All reviewed patches have been landed. Closing bug. For the record, fast/css/pseudo-empty-display-none.html tests the static :empty display:none case. (In reply to comment #7) > Done, looks fine this time round. Thanks! (In reply to comment #11) > Thanks! Thinking we should add a test for the reverse case for completeness: non-empty elements should gain :empty style if made empty by page dynamics. Reopening to attach new patch. Created attachment 129802 [details]
Patch
Comment on attachment 129802 [details] Patch Rejecting attachment 129802 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: _by_email return self._reviewer_only(self.account_by_email(email)) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 632, in account_by_email return self._email_to_account_map().get(email.lower()) if email else None File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 525, in _email_to_account_map assert(email not in self._accounts_by_email) # We should never have duplicate emails. AssertionError Full output: http://queues.webkit.org/results/11801214 Comment on attachment 129802 [details] Patch Clearing flags on attachment: 129802 Committed r109651: <http://trac.webkit.org/changeset/109651> All reviewed patches have been landed. Closing bug. *** Bug 75294 has been marked as a duplicate of this bug. *** |