Bug 79734 – :empty still applies to elements made non-empty via page dynamics

• Component: CSS
• Status: RESOLVED FIXED

[noel gordon]

Create empty elements with :empty class styling.  These elements don't display as expected.  Change the content of the elements using js to make them non-empty.  The elements still don't display and they should.

Reproduction Steps:
  1) Open test case, two green boxes are shown.
  2) Click on the page.

Expected result:
  Three green boxes should appear.

Actual result:
  The third green box does not appear.

[noel gordon]

Created attachment 129164 [details]
test case

[noel gordon]

*** Bug 79730 has been marked as a duplicate of this bug. ***

[noel gordon]

Other browsers tested:

   Safari 5.1.2 (6534.52.7, 535+) : FAIL
   Chrome 19.0.1049.3 dev Mac : FAIL
   Firefox 10.0.2 Mac :  OK
   IE9/10 Win: OK

[Joe Thomas]

Created attachment 129498 [details]
ProposedPatch

[WebKit Review Bot]

Comment on attachment 129498 [details]
ProposedPatch

Rejecting attachment 129498 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11770534

[Joe Thomas]

Can someone help me to land this patch? It failed at the commit-queue with false error.

[noel gordon]

Done, looks fine this time round.

[WebKit Review Bot]

Comment on attachment 129498 [details]
ProposedPatch

Clearing flags on attachment: 129498

Committed r109417: <http://trac.webkit.org/changeset/109417>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[noel gordon]

For the record, fast/css/pseudo-empty-display-none.html tests the static :empty display:none case.

[Joe Thomas]

(In reply to comment #7)
> Done, looks fine this time round.

Thanks!

[noel gordon]

(In reply to comment #11)
> Thanks!

Thinking we should add a test for the reverse case for completeness: non-empty elements should gain :empty style if made empty by page dynamics.

[noel gordon]

Reopening to attach new patch.

[noel gordon]

Created attachment 129802 [details]
Patch

[WebKit Review Bot]

Comment on attachment 129802 [details]
Patch

Rejecting attachment 129802 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
_by_email
    return self._reviewer_only(self.account_by_email(email))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 632, in account_by_email
    return self._email_to_account_map().get(email.lower()) if email else None
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 525, in _email_to_account_map
    assert(email not in self._accounts_by_email)  # We should never have duplicate emails.
AssertionError

Full output: http://queues.webkit.org/results/11801214

[noel gordon]

Comment on attachment 129802 [details]
Patch

Clearing flags on attachment: 129802

Committed r109651: <http://trac.webkit.org/changeset/109651>

[noel gordon]

All reviewed patches have been landed.  Closing bug.

[David Barr]

*** Bug 75294 has been marked as a duplicate of this bug. ***