Bug 79466

Summary:

[WK2] [GTK] Destructor not invoked in EditorClientFrameDestructionObserver

Product:

WebKit

Reporter:

Sergio Villar Senin <svillar>

Component:

WebKitGTK

Assignee:

Sergio Villar Senin <svillar>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

svillar

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Sergio Villar Senin 2012-02-24 01:54:33 PST

One of the changes suggested to my patch in https://bugs.webkit.org/show_bug.cgi?id=79252 was to replace an explicit cast plus a delete by a plain delete that takes a void* as argument.

The problem of that approach is that the delete frees the object's memory but does not invoke the destructor, something that is a must for us.

Comment 1 Sergio Villar Senin 2012-02-24 01:58:21 PST

Created attachment 128690 [details]
Patch

Comment 2 Sergio Villar Senin 2012-02-24 02:19:19 PST

Comment on attachment 128690 [details]
Patch

Clearing flags on attachment: 128690

Committed r108760: <http://trac.webkit.org/changeset/108760>

Comment 3 Sergio Villar Senin 2012-02-24 02:19:26 PST

All reviewed patches have been landed.  Closing bug.