Bug 79460

Summary: RunLoop should be an event processing loop for all threads.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED    
Severity: Normal CC: andersca, ap, commit-queue, dimich, enne, jamesr, jbates, levin, menard, nduca, paroga, sam, skyul, tonikitoo, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
andersca: review-
ScrollThread patch none

Dongseong Hwang
Reported 2012-02-24 00:35:26 PST
RunLoop origins from CFRunLoop of Cocoa that is part of the fundamental infrastructure associated with threads. RunLoop can be used as a common event loop on every threads in WebKit. For example, ScrollThread can use RunLoop in order to remove boilerplate code related to handle an event loop and its own tasks. Referential bugs : Bug 66962 , Bug 76751
Attachments
patch (12.39 KB, patch)
2012-02-24 00:36 PST, Dongseong Hwang 		andersca: review-
DetailsFormatted DiffDiff
ScrollThread patch (10.31 KB, text/plain)
2012-02-24 02:48 PST, Dongseong Hwang 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2012-02-24 00:36:45 PST
Created attachment 128677 [details] patch
Dongseong Hwang
Comment 2 2012-02-24 00:37:59 PST
If this patch will be passed, I want to apply following classes. ScrollingThread StorageThread FileThread DatabaseThread
Dongseong Hwang
Comment 3 2012-02-24 00:47:24 PST
(In reply to comment #0) > RunLoop origins from CFRunLoop of Cocoa that is part of the fundamental > infrastructure associated with threads. Android Looper is also very similar to CFRunLoop. Looper and Handler in Android is very comfortable to communicate between threads. I want something like those.
Dongseong Hwang
Comment 4 2012-02-24 02:48:24 PST
Created attachment 128696 [details] ScrollThread patch This patch can makes ScrollThread succinct.
Anders Carlsson
Comment 5 2012-02-24 10:11:28 PST
Comment on attachment 128677 [details] patch This doesn't make sense, there's no point in calling RunLoop::run() on anything other than the current run loop.
Dongseong Hwang
Comment 6 2012-02-24 20:59:23 PST
(In reply to comment #5) > (From update of attachment 128677 [details]) > This doesn't make sense, there's no point in calling RunLoop::run() on anything other than the current run loop. Yes, only the current run loop calls RunLoop::run() now. But, if changing RunLoop::run() from static to normal member method, we can use RunLoop in another thread like attachment 128696 [details]. I sumited this patch because I agree with Carlsson's change log of revision 106565. "Hopefully we'll be able to make ScrollingThread use the new WebCore::RunLoop class eventually." What point do I need to do more?
Dongseong Hwang
Comment 7 2012-05-03 03:34:38 PDT
I think Bug 51857 is the meta bug of this bug.
Note You need to log in before you can comment on or make changes to this bug.