RESOLVED CONFIGURATION CHANGED 76751
Everyone now implements RunLoop 
https://bugs.webkit.org/show_bug.cgi?id=76751
Summary Everyone now implements RunLoop
Sam Weinig
Reported 2012-01-20 16:13:15 PST
We have RunLoop (WebCore/platform/RunLoop.h) implementations for Mac, Windows, Qt, and Gtk. To make it usable in WebCore, we need a Chromium implementation as well.
Attachments
Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-01-20 16:22:34 PST
I think in Chromium this could be implemented on top of WebThread once https://bugs.webkit.org/show_bug.cgi?id=76012 lands.
Sam Weinig
Comment 2 2012-01-20 17:01:41 PST
(In reply to comment #1) > I think in Chromium this could be implemented on top of WebThread once https://bugs.webkit.org/show_bug.cgi?id=76012 lands. That seems like it would be wrong from a layering perspective. WebCore should not depend on WebKit. Perhaps WebThread could be implemented in terms of RunLoop, or whatever WebThread is implemented in terms of could be the basis for both.
James Robinson
Comment 3 2012-01-20 17:05:03 PST
(In reply to comment #2) > (In reply to comment #1) > > I think in Chromium this could be implemented on top of WebThread once https://bugs.webkit.org/show_bug.cgi?id=76012 lands. > > That seems like it would be wrong from a layering perspective. WebCore should not depend on WebKit. Perhaps WebThread could be implemented in terms of RunLoop, or whatever WebThread is implemented in terms of could be the basis for both. We're planning to move WebThread to Platform/ to resolve this.
Sam Weinig
Comment 4 2012-01-20 17:59:42 PST
(In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > I think in Chromium this could be implemented on top of WebThread once https://bugs.webkit.org/show_bug.cgi?id=76012 lands. > > > > That seems like it would be wrong from a layering perspective. WebCore should not depend on WebKit. Perhaps WebThread could be implemented in terms of RunLoop, or whatever WebThread is implemented in terms of could be the basis for both. > > We're planning to move WebThread to Platform/ to resolve this. Hm. The Source/Platform directory is very confusing to me at the moment. It was supposed to be where we moved Source/WebCore/platform initially, but it seems like it is holding some Chrome API right now, and nothing that should be used from cross platform code.
James Robinson
Comment 5 2012-01-20 18:03:58 PST
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (In reply to comment #1) > > > > I think in Chromium this could be implemented on top of WebThread once https://bugs.webkit.org/show_bug.cgi?id=76012 lands. > > > > > > That seems like it would be wrong from a layering perspective. WebCore should not depend on WebKit. Perhaps WebThread could be implemented in terms of RunLoop, or whatever WebThread is implemented in terms of could be the basis for both. > > > > We're planning to move WebThread to Platform/ to resolve this. > > Hm. The Source/Platform directory is very confusing to me at the moment. It was supposed to be where we moved Source/WebCore/platform initially, but it seems like it is holding some Chrome API right now, and nothing that should be used from cross platform code. That's just because we haven't figured out how to move WebCore/platform code into there in a way that compiles on all platforms yet. I've been planning to wait for the Source/WTF move to happen successfully, then do whatever was necessary to make that happen and start moving WebCore/platform code there.
Stephen Chenney
Comment 6 2013-04-12 08:11:43 PDT
There is no more Chromium in WebKit, so whatever depends on this can now move forward.
Note You need to log in before you can comment on or make changes to this bug.