| Summary: | [DFG] Misuse of WeakJSConstants in silentFillGPR code. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | barraclough, eric, ggaren, webkit.review.bot | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Filip Pizlo
2012-02-11 14:36:11 PST
Created attachment 126647 [details]
the patch
Going to attempt to write a test that repros this. If I can't after some amount of trying then I'll land without a test. Created attachment 126655 [details]
the patch with test case
Attachment 126655 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/JavaScriptCore/ChangeLog:31: Line contains tab character. [whitespace/tab] [5]
Source/JavaScriptCore/ChangeLog:32: Line contains tab character. [whitespace/tab] [5]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 126655 [details] the patch with test case View in context: https://bugs.webkit.org/attachment.cgi?id=126655&action=review Why does this test repeat 1000 times? > Source/JavaScriptCore/ChangeLog:20 > + https://bugs.webkit.org/show_bug.cgi?id=78062 > + <rdar://problem/10326439> <rdar://problem/10824839> Are these tabs? r=me
Please replace your tabs with spaces.
> Why does this test repeat 1000 times?
It's the best way we have to test the optimizing compiler. :(
(In reply to comment #7) > (From update of attachment 126655 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=126655&action=review > > Why does this test repeat 1000 times? > > > Source/JavaScriptCore/ChangeLog:20 > > + https://bugs.webkit.org/show_bug.cgi?id=78062 > > + <rdar://problem/10326439> <rdar://problem/10824839> > > Are these tabs? Yes. :-( Stupid emacs! Somehow I missed this, but fixed it in a later commit. (In reply to comment #8) > r=me > > Please replace your tabs with spaces. Already fixed! By the way, I landed the code with the test case (thanks to Sam's rubber stamp) in http://trac.webkit.org/changeset/107492 > > > Why does this test repeat 1000 times? > > It's the best way we have to test the optimizing compiler. :( |