Bug 78340

Summary: Add WindowsExtras.h
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Bug Depends on:    
Bug Blocks: 76781, 78341    
Attachments:
Description Flags
Patch
none
Patch aroben: review+, aroben: commit-queue-

Patrick R. Gansterer
Reported 2012-02-10 02:22:16 PST
Add WindowsExtras.h
Attachments
Patch (5.59 KB, patch)
2012-02-10 02:26 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (5.59 KB, patch)
2012-02-10 02:49 PST, Patrick R. Gansterer 		aroben: review+
aroben: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2012-02-10 02:26:02 PST
Created attachment 126482 [details] Patch
Patrick R. Gansterer
Comment 2 2012-02-10 02:49:50 PST
Created attachment 126484 [details] Patch
Adam Roben (:aroben)
Comment 3 2012-02-13 07:30:12 PST
Comment on attachment 126484 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126484&action=review > Source/WebCore/platform/win/WindowsExtras.h:32 > +inline void* getWindowPointer(HWND hWnd, int index = 0) I think it would be clearer to make index a required parameter. (Ditto for the setter.)
Patrick R. Gansterer
Comment 4 2012-02-13 08:30:56 PST
Committed r107574: <http://trac.webkit.org/changeset/107574>
Note You need to log in before you can comment on or make changes to this bug.