| Summary: | Switch svg/custom tests to repaint harness | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||||
| Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dglazkov, ossy, rhodovan.u-szeged, schenney, webkit.review.bot, zherczeg, zimmermann | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 77736, 78332 | ||||||||
| Bug Blocks: | 77541 | ||||||||
| Attachments: |
|
||||||||
|
Description
Nikolas Zimmermann
2012-02-08 08:16:09 PST
Created attachment 126085 [details]
Patch
Created attachment 126262 [details]
Patch v2
Comment on attachment 126262 [details]
Patch v2
LGTM!
Committed r107207: <http://trac.webkit.org/changeset/107207> Comment on attachment 126262 [details] Patch v2 Attachment 126262 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11487197 New failing tests: platform/chromium/compositing/layout-width-change.html svg/carto.net/slider.svg (In reply to comment #5) > (From update of attachment 126262 [details]) > Attachment 126262 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/11487197 > > New failing tests: > platform/chromium/compositing/layout-width-change.html > svg/carto.net/slider.svg For the record, these are not related to this bug, it only changed layout tests, and none in those directories. (In reply to comment #4) > Committed r107207: <http://trac.webkit.org/changeset/107207> Reopen, because it made the following tests assert on Qt in debug mode: svg/custom/mask-child-changes.svg svg/custom/mask-invalidation.svg svg/custom/absolute-sized-content-with-resources.xhtml ASSERTION FAILED: m_transparencyCount > 0 ../../../../Source/WebCore/platform/graphics/GraphicsContext.cpp(346) : void WebCore::GraphicsContext::endTransparencyLayer() (In reply to comment #7) > (In reply to comment #4) > > Committed r107207: <http://trac.webkit.org/changeset/107207> > > Reopen, because it made the following tests assert on Qt in debug mode: > svg/custom/mask-child-changes.svg > svg/custom/mask-invalidation.svg > svg/custom/absolute-sized-content-with-resources.xhtml > > ASSERTION FAILED: m_transparencyCount > 0 > ../../../../Source/WebCore/platform/graphics/GraphicsContext.cpp(346) : void WebCore::GraphicsContext::endTransparencyLayer() hm, I guess this only exposes a Qt bug - that's now visible due the changed timing. It's not something I can fix without a Qt build - You forgot to reopen btw. (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #4) > > > Committed r107207: <http://trac.webkit.org/changeset/107207> > > > > Reopen, because it made the following tests assert on Qt in debug mode: > > svg/custom/mask-child-changes.svg > > svg/custom/mask-invalidation.svg > > svg/custom/absolute-sized-content-with-resources.xhtml > > > > ASSERTION FAILED: m_transparencyCount > 0 > > ../../../../Source/WebCore/platform/graphics/GraphicsContext.cpp(346) : void WebCore::GraphicsContext::endTransparencyLayer() > > hm, I guess this only exposes a Qt bug - that's now visible due the changed timing. It's not something I can fix without a Qt build - You forgot to reopen btw. :-( Zoltán or Reni or any other Qt and svg expert, could you check this? Comment on attachment 126262 [details] Patch v2 Cleared Andreas Kling's review+ from obsolete attachment 126262 [details] so that this bug does not appear in http://webkit.org/pending-commit. I'm closing this bug, we can move the Qt specific fixing into bug 78332. Committed r113360: <http://trac.webkit.org/changeset/113360> |