Bug 77846

Summary: Add "JS" prefix to JSC-specific IDLs
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, japhet, ojan, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77393    
Attachments:
Description Flags
Patch
none
Patch
none
patch for commit webkit.review.bot: commit-queue-

Description Kentaro Hara 2012-02-05 20:27:03 PST 
In bug 77693, we have added "JS" prefix to several JSC specific IDLs. In this bug, we add "JS" prefix to the remaining JSC specific IDLs. Specifically, we rename IDLs as follows:

[CustomDefineGetter] => [JSCustomDefineGetter]
[CustomDefineSetter] => [JSCustomDefineSetter]
[CustomPrototypeDefineGetter] => [JSCustomPrototypeDefineGetter]
[GenerateNativeConverter] => [JSGenerateToNativeObject]  (Note: For naming consistency with [JSGenerateToJS] and [JSCustomToNativeObject])
[DelegatingGetOwnPropertySlot] => [JSCustomGetOwnPropertySlotDelegate]  (Note: Should be prefixed "JS", should be prefixed with "Custom", and for naming consistency with [CustomGetOwnPropertySlot])
Comment 1 Kentaro Hara 2012-02-05 20:34:17 PST 
Created attachment 125558 [details]
Patch
Comment 2 Kentaro Hara 2012-02-06 20:27:35 PST 
Created attachment 125758 [details]
Patch
Comment 3 Kentaro Hara 2012-02-06 20:30:23 PST 
Comment on attachment 125758 [details]
Patch

Darin: Since there was a big conflict with bug 77451, I rebased the patch. Just in case, would you take another look at it? Thanks.
Comment 4 Darin Adler 2012-02-07 11:25:54 PST 
Comment on attachment 125758 [details]
Patch

I didn’t spot any mistakes, but I am not sure I would have. r=me
Comment 5 WebKit Review Bot 2012-02-07 12:04:35 PST 
Comment on attachment 125758 [details]
Patch

Rejecting attachment 125758 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
webkit-commit-queue/Source/WebKit/chromium/webkit --revision 120754 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 120754.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11453042
Comment 6 Kentaro Hara 2012-02-07 20:20:19 PST 
Created attachment 125990 [details]
patch for commit
Comment 7 WebKit Review Bot 2012-02-07 22:35:47 PST 
Comment on attachment 125990 [details]
patch for commit

Rejecting attachment 125990 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
webkit-commit-queue/Source/WebKit/chromium/webkit --revision 120754 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 120754.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11460267
Comment 8 Kentaro Hara 2012-02-07 22:41:26 PST 
Committed r107041: <http://trac.webkit.org/changeset/107041>