Summary: | [GStreamer] disable GStreamerGWorld when building against 0.11 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | gustavo, menard, pnormand, slomo, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 77005 | ||||||||||
Attachments: |
|
Description
Philippe Normand
2012-01-26 02:59:06 PST
Created attachment 124095 [details]
disable GStreamerGWorld when building against 0.11
Looks good and makes sense to disable now if it is going to be dropped soon anyway Comment on attachment 124095 [details]
disable GStreamerGWorld when building against 0.11
The Qt and maybe EFL ports need an update, I'll check that tomorrow.
Created attachment 130328 [details]
disable GStreamerGWorld when building against 0.11
Created attachment 130331 [details]
disable GStreamerGWorld when building against 0.11
Comment on attachment 130331 [details] disable GStreamerGWorld when building against 0.11 View in context: https://bugs.webkit.org/attachment.cgi?id=130331&action=review > Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:22 > #include "GStreamerGWorld.h" > +#ifndef GST_API_VERSION_1 I prefer the compound statement that you use below here. :) > Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.h:24 > +#ifndef GST_API_VERSION_1 > #if ENABLE(VIDEO) && USE(GSTREAMER) Ditto. Committed r109915: <http://trac.webkit.org/changeset/109915> |