Bug 77088

Summary: [GStreamer] disable GStreamerGWorld when building against 0.11
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, menard, pnormand, slomo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77005    
Attachments:
Description Flags
disable GStreamerGWorld when building against 0.11
none
disable GStreamerGWorld when building against 0.11
none
disable GStreamerGWorld when building against 0.11 mrobinson: review+

Philippe Normand
Reported 2012-01-26 02:59:06 PST
SSIA
Attachments
disable GStreamerGWorld when building against 0.11 (8.19 KB, patch)
2012-01-26 03:32 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
disable GStreamerGWorld when building against 0.11 (13.84 KB, patch)
2012-03-06 01:25 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
disable GStreamerGWorld when building against 0.11 (18.04 KB, patch)
2012-03-06 01:34 PST, Philippe Normand 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2012-01-26 03:32:00 PST
Created attachment 124095 [details] disable GStreamerGWorld when building against 0.11
Sebastian Dröge (slomo)
Comment 2 2012-01-30 02:25:16 PST
Looks good and makes sense to disable now if it is going to be dropped soon anyway
Philippe Normand
Comment 3 2012-02-27 10:16:16 PST
Comment on attachment 124095 [details] disable GStreamerGWorld when building against 0.11 The Qt and maybe EFL ports need an update, I'll check that tomorrow.
Philippe Normand
Comment 4 2012-03-06 01:25:45 PST
Created attachment 130328 [details] disable GStreamerGWorld when building against 0.11
Philippe Normand
Comment 5 2012-03-06 01:34:10 PST
Created attachment 130331 [details] disable GStreamerGWorld when building against 0.11
Martin Robinson
Comment 6 2012-03-06 06:43:45 PST
Comment on attachment 130331 [details] disable GStreamerGWorld when building against 0.11 View in context: https://bugs.webkit.org/attachment.cgi?id=130331&action=review > Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:22 > #include "GStreamerGWorld.h" > +#ifndef GST_API_VERSION_1 I prefer the compound statement that you use below here. :) > Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.h:24 > +#ifndef GST_API_VERSION_1 > #if ENABLE(VIDEO) && USE(GSTREAMER) Ditto.
Philippe Normand
Comment 7 2012-03-06 07:03:16 PST
Committed r109915: <http://trac.webkit.org/changeset/109915>
Note You need to log in before you can comment on or make changes to this bug.