Bug 77005

Summary: [GStreamer] 0.11 support for Media elements
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, levin+threading, slomo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 77085, 77086, 77087, 77088, 77089, 84029    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Philippe Normand
Reported 2012-01-25 06:40:52 PST
We should support the 0.11 APIs. A ./configure --with-gstreamer=0.11 could be used to build (defaulting to 0.10). For video rendering we will need a new video-sink that will initially provide the same features as the current 0.10 video-sink.
Attachments
Patch (59.95 KB, patch)
2012-01-25 08:01 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2012-01-25 06:58:19 PST
Also, the GStreamerGWorld module is not really worth porting as it's planned to be removed soon.
Philippe Normand
Comment 2 2012-01-25 08:01:13 PST
Created attachment 123944 [details] Patch First iteration :)
Philippe Normand
Comment 3 2012-01-25 08:05:50 PST
I can probably find a way to split this patch if needed.
WebKit Review Bot
Comment 4 2012-01-25 08:06:03 PST
Attachment 123944 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/ChangeLog', u..." exit_code: 1 Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:67: webkit_video_sink_signals is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:71: timeout_id is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:72: buffer_mutex is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:73: data_cond is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:331: need_pool is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:362: n_param_values is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:363: invocation_hint is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:387: gobject_class is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:388: gstbase_sink_class is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:389: element_class is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 10 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Philippe Normand
Comment 5 2012-01-26 02:55:11 PST
I'm going to split this in 4 patches: - build infrastructure - webkitwebsrc changes - video-sink - disable GStreamerGWorld
Philippe Normand
Comment 6 2012-01-26 03:32:54 PST
Comment on attachment 123944 [details] Patch Went through the patch split machine.
Philippe Normand
Comment 7 2012-06-19 19:48:12 PDT
Last patch landed. Next step would be to have test coverage on the bots. I'll file a separate bug for this.
Note You need to log in before you can comment on or make changes to this bug.