Summary: | Assigning to Element.prefix should throw exception when using illegal characters | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 76198 | ||||||||||
Attachments: |
|
Description
Adam Barth
2012-01-18 17:09:50 PST
Created attachment 123041 [details]
Patch
Comment on attachment 123041 [details]
Patch
Um... I think we need at least 10x this many tests for this much code. :(
Comment on attachment 123041 [details]
Patch
ok.
Created attachment 123064 [details]
Patch
Created attachment 123068 [details]
Patch
Comment on attachment 123068 [details] Patch Clearing flags on attachment: 123068 Committed r105388: <http://trac.webkit.org/changeset/105388> All reviewed patches have been landed. Closing bug. Comment on attachment 123064 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123064&action=review > Source/WebCore/dom/Node.cpp:132 > +static bool isValidNameStartCharacter(UChar c) We already have isValidNameStart and isValidNamePart functions in Document.cpp. Can we share those instead of adding new functions? > We already have isValidNameStart and isValidNamePart functions in Document.cpp. Can we share those instead of adding new functions?
Sure. Should we move the functions to QualifiedName.cpp at the same time? That seems like a more natural place for them to live.
I filed Bug 76672 on this topic. |