Bug 76414

Summary: Clean EventContext class and move phase-tweaking logic to EventDispatcher class.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: UI EventsAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 76513    
Attachments:
Description Flags
clean EventContext
none
update
none
update none

Hayato Ito
Reported 2012-01-16 18:26:38 PST
Clean EventContext class. See https://bugs.webkit.org/show_bug.cgi?id=76217#c10 for more info. This should be only refactoring, no functional changes.
Attachments
clean EventContext (4.07 KB, patch)
2012-01-16 20:41 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
update (4.08 KB, patch)
2012-01-17 20:25 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
update (4.08 KB, patch)
2012-01-17 20:46 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-01-16 20:41:26 PST
Created attachment 122707 [details] clean EventContext
Dimitri Glazkov (Google)
Comment 2 2012-01-17 09:47:19 PST
Comment on attachment 122707 [details] clean EventContext View in context: https://bugs.webkit.org/attachment.cgi?id=122707&action=review > Source/WebCore/dom/EventDispatcher.cpp:311 > + const EventContext& eventContext = m_ancestors[i-1]; I think you can do even better here: instead of exposing currentTarget, add a method that checks for equality of target and currentTarget (adjustedTargetSameAsTarget? atTarget?). This way, you aren't exposing unnecessary information from EventContext.
Hayato Ito
Comment 3 2012-01-17 20:25:44 PST
Created attachment 122865 [details] update
Hayato Ito
Comment 4 2012-01-17 20:27:13 PST
Thank you for the review. I've updated the patch. (In reply to comment #2) > (From update of attachment 122707 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=122707&action=review > > > Source/WebCore/dom/EventDispatcher.cpp:311 > > + const EventContext& eventContext = m_ancestors[i-1]; > > I think you can do even better here: instead of exposing currentTarget, add a method that checks for equality of target and currentTarget (adjustedTargetSameAsTarget? atTarget?). This way, you aren't exposing unnecessary information from EventContext. I named it EventContext::currentTargetSameAsTarget.
Hayato Ito
Comment 5 2012-01-17 20:46:47 PST
Created attachment 122867 [details] update
Hayato Ito
Comment 6 2012-01-17 20:49:54 PST
Ops. I updated the patch without the previous patch got r+. The new patch fixes one style issue. No behavior change. Could you review it again?
WebKit Review Bot
Comment 7 2012-01-17 21:50:11 PST
Comment on attachment 122867 [details] update Clearing flags on attachment: 122867 Committed r105241: <http://trac.webkit.org/changeset/105241>
WebKit Review Bot
Comment 8 2012-01-17 21:50:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.