Bug 76341 – [Qt] Enable -Werror on Mac OS X builds

• Component: WebKit Qt
• Status: RESOLVED INVALID

[Alexander Færøy]

SSIA.

[Alexander Færøy]

Created attachment 122557 [details]
Patch

[Alexander Færøy]

Adding Tor Arne for review.

[Antonio Gomes]

Comment on attachment 122557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122557&action=review

> Tools/ChangeLog:1
> [phone]  Alexander Færøy  <[e-mail]>

that did not work

[Alexander Færøy]

(In reply to comment #3)
> that did not work

So far, all my patches has looked like that in the review tool, but they look fine when they are commited. 

The curse of having dodgy letters in the surname :-(

[Simon Hausmann]

Comment on attachment 122557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122557&action=review

>> Tools/ChangeLog:1
>> [phone]  Alexander Færøy  <[e-mail]>
> 
> that did not work

Actually it's correct. It's just that in bugzilla it's not shown correctly, but when landing the utf-8 encoding is preserved correctly.

[Tor Arne Vestbø]

(In reply to comment #1)
> Created an attachment (id=122557) [details]
> Patch

Do you have a bug tracking the warnings that are left to fix before we land this?

[Csaba Osztrogonác]

Why didn't you guys land it? Is there any warning now on Mac?

[Alexander Færøy]

There are still some warnings that needs to get fixed before this can be landed.

[Eric Seidel (no email)]

Are those warnings tracked?  Should this be resolved "LATER" and fixed once those are?

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.