Summary: | REGRESSION (r104174): 500+ tests failing on Windows | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Tools / Tests | Assignee: | Per Arne Vollan <pvollan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, adele, bfulgham, ddkilzer, fsamuel, pvollan, simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly, Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows 7 | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=64512 | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2012-01-10 08:12:44 PST
Mac DRT does a few things to reset zooming/scaling between each test: http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm?rev=104360#L1202 Win DRT doesn't do all the same things: http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp?rev=104360#L900 (In reply to comment #2) > Mac DRT does a few things to reset zooming/scaling between each test: > > http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm?rev=104360#L1202 > > Win DRT doesn't do all the same things: > > http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp?rev=104360#L900 Sorry, I didn't realize this was needed. I didn't see the issue on chromium platforms. I don't have access to a Mac at the moment to do some testing but I can look into this later tonight, if you don't have the cycles to fix it/investigate it yourself. Any update on this? Created attachment 280591 [details]
Patch
Comment on attachment 280591 [details]
Patch
Are you planning to update expectations after landing this?
(In reply to comment #6) > Comment on attachment 280591 [details] > Patch > > Are you planning to update expectations after landing this? Yes, I had planned to update expectations, but I couldn't find any skipped page scale tests. I will have a second look. Thanks for reviewing! Committed r201720: <https://trac.webkit.org/changeset/201720> |