Bug 75796

Summary:

Rename checkNodeSecurity and allowsAccessFromFrame to have sensible names

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, dglazkov, eric, japhet, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

75793

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch	none

Adam Barth

Reported 2012-01-08 02:30:27 PST

Rename checkNodeSecurity and allowsAccessFromFrame to have sensible names

Attachments
Patch (17.16 KB, patch) 2012-01-08 02:30 PST, Adam Barth	no flags	Details Formatted Diff Diff
Patch for landing (18.49 KB, patch) 2012-01-08 14:41 PST, Adam Barth	no flags	Details Formatted Diff Diff
Patch (20.63 KB, patch) 2012-02-02 15:38 PST, Adam Barth	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2012-01-08 02:30:59 PST

Created attachment 121577 [details] Patch

WebKit Review Bot

Comment 2 2012-01-08 02:55:11 PST

Comment on attachment 121577 [details] Patch Attachment 121577 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11166171

Adam Barth

Comment 3 2012-01-08 14:41:29 PST

Created attachment 121590 [details] Patch for landing

WebKit Review Bot

Comment 4 2012-01-08 15:15:59 PST

Comment on attachment 121590 [details] Patch for landing Clearing flags on attachment: 121590 Committed r104412: <http://trac.webkit.org/changeset/104412>

WebKit Review Bot

Comment 5 2012-01-08 15:16:03 PST

All reviewed patches have been landed. Closing bug.

Ryosuke Niwa

Comment 6 2012-01-08 18:32:54 PST

It seems like this patch broke two layout tests: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fdom%2FWindow%2Fwindow-properties.html%2Chttp%2Ftests%2Fsecurity%2Fcross-frame-access-put.html&group=%40ToT%20-%20webkit.org

Darin Adler

Comment 7 2012-01-08 19:11:45 PST

A substantial improvement. Wish I was around earlier today to comment on this. I would prefer shouldAllowAccessToNode rather than allowAccessToNode because the latter sounds like a verb phrase, and so seems like it could be a function that is used to “allow access” to a node. We might also consider just calling these shouldAllowAccessTo and using overloading, since the types are distinct; on the other hand, leaving out the noun makes the names less clear, so we probably shouldn’t.

Adam Barth

Comment 8 2012-01-08 19:14:50 PST

Ok. Will fix.

Adam Barth

Comment 9 2012-01-08 19:15:01 PST

Re-open to remind me to fix.

Adam Barth

Comment 10 2012-02-02 15:38:35 PST

Created attachment 125199 [details] Patch

Eric Seidel (no email)

Comment 11 2012-02-02 15:40:52 PST

Comment on attachment 125199 [details] Patch OK.

WebKit Review Bot

Comment 12 2012-02-02 19:24:00 PST

Comment on attachment 125199 [details] Patch Clearing flags on attachment: 125199 Committed r106618: <http://trac.webkit.org/changeset/106618>

WebKit Review Bot

Comment 13 2012-02-02 19:24:05 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.