Summary: | Rename checkNodeSecurity and allowsAccessFromFrame to have sensible names | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | darin, dglazkov, eric, japhet, rniwa, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 75793 | ||||||||||
Attachments: |
|
Description
Adam Barth
2012-01-08 02:30:27 PST
Created attachment 121577 [details]
Patch
Comment on attachment 121577 [details] Patch Attachment 121577 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11166171 Created attachment 121590 [details]
Patch for landing
Comment on attachment 121590 [details] Patch for landing Clearing flags on attachment: 121590 Committed r104412: <http://trac.webkit.org/changeset/104412> All reviewed patches have been landed. Closing bug. It seems like this patch broke two layout tests: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fdom%2FWindow%2Fwindow-properties.html%2Chttp%2Ftests%2Fsecurity%2Fcross-frame-access-put.html&group=%40ToT%20-%20webkit.org A substantial improvement. Wish I was around earlier today to comment on this. I would prefer shouldAllowAccessToNode rather than allowAccessToNode because the latter sounds like a verb phrase, and so seems like it could be a function that is used to “allow access” to a node. We might also consider just calling these shouldAllowAccessTo and using overloading, since the types are distinct; on the other hand, leaving out the noun makes the names less clear, so we probably shouldn’t. Ok. Will fix. Re-open to remind me to fix. Created attachment 125199 [details]
Patch
Comment on attachment 125199 [details]
Patch
OK.
Comment on attachment 125199 [details] Patch Clearing flags on attachment: 125199 Committed r106618: <http://trac.webkit.org/changeset/106618> All reviewed patches have been landed. Closing bug. |