Bug 75787

Summary: Layout Test fast/text/international/spaces-combined-in-vertical-text.html is failing
Product: WebKit Reporter: Dmitry Lomov <dslomov>
Component: Tools / TestsAssignee: Ken Buchanan <kenrb>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, inferno, kenrb, mitz, pnormand, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dmitry Lomov
Reported 2012-01-07 16:01:43 PST
The following layout test is failing (timing out) on chromium-linux, chromium-mac fast/text/international/spaces-combined-in-vertical-text.html Probable cause: http://trac.webkit.org/changeset/104322.
Attachments
Patch (2.23 KB, patch)
2012-01-19 07:54 PST, Ken Buchanan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Abhishek Arya
Comment 1 2012-01-08 21:30:38 PST
Did anyone rollout his patch or landed a test expectations update ?? Are you sure it is his patch, because cq landed it and chrome bots look green. Me and him are both on vacation this week. Ken, should take a look at this early next week.
Alexey Proskuryakov
Comment 2 2012-01-09 10:50:34 PST
*** Bug 75833 has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
Comment 3 2012-01-09 10:51:04 PST
*** Bug 75752 has been marked as a duplicate of this bug. ***
Ken Buchanan
Comment 4 2012-01-19 07:54:44 PST
Created attachment 123129 [details] Patch
Ken Buchanan
Comment 5 2012-01-19 07:58:36 PST
The test is the one that I added in r104322, but the problem is that in the patch I was sloppy with handling loop iteration in skipLeadingWhitespace. I think the fix is fairly straightforward. ap do you care to review?
Simon Fraser (smfr)
Comment 6 2012-01-19 08:30:23 PST
*** Bug 76554 has been marked as a duplicate of this bug. ***
Ken Buchanan
Comment 7 2012-01-19 08:45:23 PST
smfr can you review this? I don't know that I need to be picky about the reviewer, it's just a logic fix to prevent getting stuck in that loop.
WebKit Review Bot
Comment 8 2012-01-19 10:05:48 PST
Comment on attachment 123129 [details] Patch Clearing flags on attachment: 123129 Committed r105423: <http://trac.webkit.org/changeset/105423>
WebKit Review Bot
Comment 9 2012-01-19 10:05:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.