Summary: | DOMWindow should be a FrameDestructionObserver | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | darin, dglazkov, eric, gustavo, webkit.review.bot, xan.lopez | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 75693 | ||||||||||
Bug Blocks: | 75699 | ||||||||||
Attachments: |
|
Description
Adam Barth
2012-01-06 02:50:16 PST
Created attachment 121417 [details]
Patch
This is going to fail to compile until Bug 75693 lands. Created attachment 121419 [details]
Patch
Comment on attachment 121419 [details] Patch Attachment 121419 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11147355 Comment on attachment 121419 [details] Patch Attachment 121419 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11146294 Comment on attachment 121419 [details] Patch Attachment 121419 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11144309 Comment on attachment 121419 [details] Patch Attachment 121419 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11147376 Comment on attachment 121419 [details]
Patch
r=me assuming it builds and passes tests.
Created attachment 121516 [details]
Patch for landing
Comment on attachment 121516 [details] Patch for landing Clearing flags on attachment: 121516 Committed r104372: <http://trac.webkit.org/changeset/104372> All reviewed patches have been landed. Closing bug. Seems DOMWindow could have privately derived from FrameDestructionObserver rather than publicly. Comment on attachment 121516 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=121516&action=review > Source/WebCore/page/DOMWindow.h:-93 > - Frame* frame() const { return m_frame; } This method now gets inherited from FrameDestructionObserver and needs to be public. Comment on attachment 121516 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=121516&action=review >> Source/WebCore/page/DOMWindow.h:-93 >> - Frame* frame() const { return m_frame; } > > This method now gets inherited from FrameDestructionObserver and needs to be public. The way to do that and keep the rest of FrameDestructionObserver private is to write: using FrameDestructionObserver::frame; |