Bug 75697

Summary: DOMWindow should be a FrameDestructionObserver
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dglazkov, eric, gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 75693    
Bug Blocks: 75699    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Adam Barth
Reported 2012-01-06 02:50:16 PST
DOMWindow should be a FrameDestructionObserver
Attachments
Patch (5.97 KB, patch)
2012-01-06 02:51 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (6.24 KB, patch)
2012-01-06 02:53 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.93 KB, patch)
2012-01-06 16:11 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-01-06 02:51:42 PST
Created attachment 121417 [details] Patch
Adam Barth
Comment 2 2012-01-06 02:52:12 PST
This is going to fail to compile until Bug 75693 lands.
Adam Barth
Comment 3 2012-01-06 02:53:47 PST
Created attachment 121419 [details] Patch
Early Warning System Bot
Comment 4 2012-01-06 03:06:38 PST
Comment on attachment 121419 [details] Patch Attachment 121419 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11147355
WebKit Review Bot
Comment 5 2012-01-06 03:07:53 PST
Comment on attachment 121419 [details] Patch Attachment 121419 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11146294
Gyuyoung Kim
Comment 6 2012-01-06 03:10:55 PST
Comment on attachment 121419 [details] Patch Attachment 121419 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11144309
Gustavo Noronha (kov)
Comment 7 2012-01-06 04:28:03 PST
Comment on attachment 121419 [details] Patch Attachment 121419 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11147376
Alexey Proskuryakov
Comment 8 2012-01-06 10:36:39 PST
Comment on attachment 121419 [details] Patch r=me assuming it builds and passes tests.
Adam Barth
Comment 9 2012-01-06 16:11:01 PST
Created attachment 121516 [details] Patch for landing
WebKit Review Bot
Comment 10 2012-01-06 19:12:18 PST
Comment on attachment 121516 [details] Patch for landing Clearing flags on attachment: 121516 Committed r104372: <http://trac.webkit.org/changeset/104372>
WebKit Review Bot
Comment 11 2012-01-06 19:12:23 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 12 2012-01-07 00:01:14 PST
Seems DOMWindow could have privately derived from FrameDestructionObserver rather than publicly.
Adam Barth
Comment 13 2012-01-07 00:05:05 PST
Comment on attachment 121516 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=121516&action=review > Source/WebCore/page/DOMWindow.h:-93 > - Frame* frame() const { return m_frame; } This method now gets inherited from FrameDestructionObserver and needs to be public.
Darin Adler
Comment 14 2012-01-07 00:12:35 PST
Comment on attachment 121516 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=121516&action=review >> Source/WebCore/page/DOMWindow.h:-93 >> - Frame* frame() const { return m_frame; } > > This method now gets inherited from FrameDestructionObserver and needs to be public. The way to do that and keep the rest of FrameDestructionObserver private is to write: using FrameDestructionObserver::frame;
Note You need to log in before you can comment on or make changes to this bug.