|Summary:||Move FrameDestructionObserver to its own file|
|Product:||WebKit||Reporter:||Adam Barth <abarth>|
|Component:||New Bugs||Assignee:||Adam Barth <abarth>|
|Severity:||Normal||CC:||eric, rakuco, webkit.review.bot|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Adam Barth 2012-01-06 02:30:48 PST
Move FrameDestructionObserver to its own file
Comment 3 Eric Seidel (no email) 2012-01-06 02:59:26 PST
Comment on attachment 121416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121416&action=review LGTM. > Source/WebCore/page/FrameDestructionObserver.h:42 > + Frame* m_frame; Having the storage on FrameDestructionObserver is probably slightly controvertial. Theoretically one might want a FrameDestructionObserver that had its own Frame storage, but the common case probably wants this concrete instance. We may eventually want to separate out the ABC from this common concrete instance.
Comment 4 Adam Barth 2012-01-06 03:05:01 PST
Yes, that's a good point. So far, all the subclasses I've seen want this storage, but that might change in the future.
Comment 5 Eric Seidel (no email) 2012-01-06 03:12:52 PST
I should have acxtually mentioned it in my previous review, since it was the other bug which moved the storage down into the (previously) ABC. Anyway, I think turning FrameDestructionObserver into a concrete class with Frame* storage is good. We might want to add a coment about how it's a slight violation of the interface paradigm. :)
Comment 6 Adam Barth 2012-01-06 03:33:42 PST
Comment on attachment 121416 [details] Patch Forgot the Xcodeproj file.