Bug 75693

Summary: Move FrameDestructionObserver to its own file
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 75697    
Attachments:
Description Flags
Patch
none
Patch eric: review+, abarth: commit-queue-

Adam Barth
Reported 2012-01-06 02:30:48 PST
Move FrameDestructionObserver to its own file
Attachments
Patch (11.97 KB, patch)
2012-01-06 02:32 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (11.42 KB, patch)
2012-01-06 02:34 PST, Adam Barth 		eric: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-01-06 02:32:02 PST
Created attachment 121415 [details] Patch
Adam Barth
Comment 2 2012-01-06 02:34:18 PST
Created attachment 121416 [details] Patch
Eric Seidel (no email)
Comment 3 2012-01-06 02:59:26 PST
Comment on attachment 121416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121416&action=review LGTM. > Source/WebCore/page/FrameDestructionObserver.h:42 > + Frame* m_frame; Having the storage on FrameDestructionObserver is probably slightly controvertial. Theoretically one might want a FrameDestructionObserver that had its own Frame storage, but the common case probably wants this concrete instance. We may eventually want to separate out the ABC from this common concrete instance.
Adam Barth
Comment 4 2012-01-06 03:05:01 PST
Yes, that's a good point. So far, all the subclasses I've seen want this storage, but that might change in the future.
Eric Seidel (no email)
Comment 5 2012-01-06 03:12:52 PST
I should have acxtually mentioned it in my previous review, since it was the other bug which moved the storage down into the (previously) ABC. Anyway, I think turning FrameDestructionObserver into a concrete class with Frame* storage is good. We might want to add a coment about how it's a slight violation of the interface paradigm. :)
Adam Barth
Comment 6 2012-01-06 03:33:42 PST
Comment on attachment 121416 [details] Patch Forgot the Xcodeproj file.
Adam Barth
Comment 7 2012-01-06 14:55:00 PST
Committed r104344: <http://trac.webkit.org/changeset/104344>
Note You need to log in before you can comment on or make changes to this bug.