Bug 75474

Summary: [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, mrobinson
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 72589    
Attachments:
Description Flags
Patch proposal
none
Patch proposal pnormand: review+

Mario Sanchez Prada
Reported 2012-01-03 08:19:05 PST
Currently, any executable file placed under the WK2GTK's API tests directory will be executed, no matter it has or not the "test" or "Test" prefix, which is a problem at least for the patch about bug 72589, since we need to place there a helper program that is not a test, but an "accessibility test server" to be inspected from TestWebKitAccessibility (the actual test). Initial solution in bug 72589 to this was to include the WebKit2APITests/AccessibilityTestServer file in the SKIPPED list in run-gtk-tests, but it seems that a better solution would be just to make run-gtk-tests to ignore files without the "test" (used for WK1's API tests) and the "Test" (used in WK2) prefix. So, this bug is about that.
Attachments
Patch proposal (2.00 KB, patch)
2012-01-03 08:26 PST, Mario Sanchez Prada 		no flags
DetailsFormatted DiffDiff
Patch proposal (2.00 KB, patch)
2012-01-03 08:37 PST, Mario Sanchez Prada 		pnormand: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1 2012-01-03 08:26:33 PST
Created attachment 120949 [details] Patch proposal
Carlos Garcia Campos
Comment 2 2012-01-03 08:37:20 PST
Comment on attachment 120949 [details] Patch proposal Looks good to me, I would probably use if not test_file.lower().startswith("test") but I guess it's a matter of taste.
Mario Sanchez Prada
Comment 3 2012-01-03 08:37:58 PST
Created attachment 120953 [details] Patch proposal A better approach
Mario Sanchez Prada
Comment 4 2012-01-03 09:00:26 PST
Committed r103943: <http://trac.webkit.org/changeset/103943>
Note You need to log in before you can comment on or make changes to this bug.