Bug 75347

Summary: getComputedStyle for border-image is not implemented.
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: CSSAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, koivisto, macpherson, simon.fraser, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 13658    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Alexis Menard (darktears)
Reported 2011-12-29 05:39:33 PST
getComputedStyle for border-image is not implemented.
Attachments
Patch (12.22 KB, patch)
2011-12-29 05:43 PST, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Patch (11.92 KB, patch)
2012-01-04 04:31 PST, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Patch (11.80 KB, patch)
2012-01-04 04:41 PST, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.53 KB, patch)
2012-01-04 11:26 PST, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2011-12-29 05:43:32 PST
Created attachment 120736 [details] Patch
Tony Chang
Comment 2 2012-01-03 11:47:25 PST
Comment on attachment 120736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120736&action=review > Source/WebCore/ChangeLog:8 > + Implement getComputedStyle for border-color. Nit: border-image > LayoutTests/fast/css/getComputedStyle/computed-style-border-image.html:23 > +shouldBe("computedBorderImageStyle('12 11 12 11', 'border-image')", "'none 12 11 1 0px stretch'"); It doesn't look like this is something that WebKit can parse properly. I think you need a '/' between border-image-slice, border-image-width and border-image-outset.
Alexis Menard (darktears)
Comment 3 2012-01-04 04:31:28 PST
Created attachment 121098 [details] Patch
Alexis Menard (darktears)
Comment 4 2012-01-04 04:41:35 PST
Created attachment 121099 [details] Patch
Tony Chang
Comment 5 2012-01-04 10:11:42 PST
Comment on attachment 121099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121099&action=review > LayoutTests/fast/css/getComputedStyle/computed-style-border-image.html:56 > +shouldBe("computedBorderImageStyle('url(dummy://test.png) 10 / 13px / 11px', 'border-image')", "'url(dummy://test.png) 10 / 13px / 11px stretch'"); Can you add some tests that setting border-image to the value returned by getComputedStyle doesn't change the value. That is, for each of the different values: var before = window.getComputedStyle(testDiv).getPropertyValue('border-image'); testDiv.style.borderImage = 'none'; testDiv.style.borderImage = before; assert(window.getComputedStyle(testDiv).getPropertyValue('border-image') == before); It would be nice to have this kind of check for all future getComputedStyle changes.
Alexis Menard (darktears)
Comment 6 2012-01-04 11:26:21 PST
Created attachment 121129 [details] Patch for landing
WebKit Review Bot
Comment 7 2012-01-05 04:56:06 PST
Comment on attachment 121129 [details] Patch for landing Clearing flags on attachment: 121129 Committed r104144: <http://trac.webkit.org/changeset/104144>
WebKit Review Bot
Comment 8 2012-01-05 04:56:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.