Bug 75221

Summary: Use OwnPtr to handle lifetime and deletion of FontFace objects
Product: WebKit Reporter: Darin Adler <darin>
Component: CSSAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: macpherson, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 41321    
Attachments:
Description Flags
Patch none

Darin Adler
Reported 2011-12-25 21:08:59 PST
Use OwnPtr to handle lifetime and deletion of FontFace objects
Attachments
Patch (6.25 KB, patch)
2011-12-25 21:13 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2011-12-25 21:13:22 PST
Created attachment 120523 [details] Patch
WebKit Review Bot
Comment 2 2011-12-28 13:12:40 PST
Comment on attachment 120523 [details] Patch Clearing flags on attachment: 120523 Committed r103779: <http://trac.webkit.org/changeset/103779>
WebKit Review Bot
Comment 3 2011-12-28 13:12:44 PST
All reviewed patches have been landed. Closing bug.
Steve Block
Comment 4 2012-01-03 06:32:31 PST
This change removed an ASSERT from CSSFontFaceSource::getFontData() which we were sometimes hitting on Android. Is the removal intentional and if so, was the ASSERT erroneous? Thanks!
Darin Adler
Comment 5 2012-01-08 22:25:39 PST
(In reply to comment #4) > This change removed an ASSERT from CSSFontFaceSource::getFontData() which we were sometimes hitting on Android. Is the removal intentional and if so, was the ASSERT erroneous? Thanks! I removed the assertion by accident. I do not know whether the assertion is correct or not. We should probably add it back.
Note You need to log in before you can comment on or make changes to this bug.